Skip to content
This repository has been archived by the owner on Nov 15, 2021. It is now read-only.

Move base datatypes to neocore #146

Merged
merged 5 commits into from
Jan 3, 2018
Merged

Move base datatypes to neocore #146

merged 5 commits into from
Jan 3, 2018

Conversation

metachris
Copy link
Contributor

  • Added neocore dependency
  • Removed base datatypes
  • Changed the imports to neocore

…eocore-imports

* 'development' of github.com:CityOfZion/neo-python:
  Add reference
  typo
  Resolve pycodestyle
  Document /neo/Core/TX/
@coveralls
Copy link

coveralls commented Jan 2, 2018

Coverage Status

Coverage decreased (-1.7%) to 66.382% when pulling 5f7998e on neocore-imports into ca1d715 on development.

@metachris
Copy link
Contributor Author

metachris commented Jan 3, 2018

Too bad coverage decreased, guess this moved a couple of files with high coverage to neopython which lowers the overall average coverage.

Edit: The good thing is that I've added loads of tests there (>90% coverage), so in fact this PR is increasing the overall coverage.

* origin/development:
  Document /neo/Network/ and /neo/Network/Payloads/
  Document /neo/Core/
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.9%) to 66.132% when pulling c7c5bb6 on neocore-imports into fdc0e10 on development.

@localhuman
Copy link
Collaborator

Great work!

@localhuman localhuman merged commit 86a62df into development Jan 3, 2018
@metachris metachris deleted the neocore-imports branch January 5, 2018 12:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants