This repository has been archived by the owner on Nov 15, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What current issue(s) does this address?, or what feature is it adding?
Currently when you try to configure an non existing event type, or simply mistype it you'll get a partially confusing error message.
The "cannot configure " message makes sense, but the one following that suggests you can type
config log on
orconfig log off
which you cannot.How did you solve this problem?
I changed the error message to:
print("Invalid config target: %s", what)
I believe that without giving a suggestion on what to do next, users will likely try
help
first and see the list of available config commands.How did you make sure your solution works?
ran unit tests. no errors
Did you add any tests?
no
Are there any special changes in the code that we should be aware of?
no