This repository has been archived by the owner on Nov 15, 2021. It is now read-only.
Localhuman rpc4 #222
Merged
Localhuman rpc4 #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metachris
added a commit
that referenced
this pull request
Feb 14, 2018
* start JsonRpcApi * disable some notification server tests for now to fix build * JSON-RPC Start proper method and error handling * Fix params parsing & getblockcount method (#186) * Fix params parsing & getblockcount method add getblockhash example * remove unnecessary ast parsing (I blame sleep) * add error handling + extra test * JsonRpcApi error handling, compatible with neo-cli * Implementing a few methods (#187) * JsonRpcApi internal error bugfix * Fix getaccountstate handling for invalid address Add test for getblock by hash failure * JsonRpcApi: added docs in markdown file neo/api/JSONRPC/neo-cli-json-rpc-docs.md * JsonRpcApi getblocksysfee * JsonRpcApi: getrawmempool (based on @ixje drycode) * JsonRpcApi: getversion * JsonRpcApi: `getrawmempool` fixes * Define VersionName in settings, removed from jsons * fix nonce * Added RPC port to json files and RPC_PORT to settings * add `getblocksysfee` error test cases (#191) * Localhuman rpc2 (#192) * update neocore to use To0xString for UInt objects in json outputs, fix some tests * fixed block serialization issue * adding hex specifiers, fix block serialization * merge, fixed tests * Updated json representations of Fixed8. Also added getrawtransaction * add validate address rpc call + tests * Adding ContractParameter for use in RPC invoke operations * adding more fixes/tests for rpc invoke related things * update to neocore 0.3.3, use ToNeoJsonString for Fixed8 * removing uneccesary imports * processing review * Update fixture and tests, added some doc strings, added 'unspent' array for tx command in prompt, updated TransactionOutput ToJson to match C# and include 'n' parameter * update requirements for neocore * update docstrings * added test for getting non-existent contract from json api * Add 'gettxout' rpc call + tests * add docs * blank line ¯\_(ツ)_/¯ * fix test broken when merging from development * Localhuman rpc4 (#222) * adding submitrawtx * adding tests for sendrawtransaction in JSONRPC * add JSONRPC api sendrawtx support * fix style * Cleanup
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unless anyone feels strongly otherwise, this should be the final functionality needed in the JSONRPC implementation for us to merge into development.
What current issue(s) does this address?, or what feature is it adding?
sendrawtransactionHow did you make sure your solution works?
Did you add any tests?
Are there any special changes in the code that we should be aware of?
Did you run
make lintandmake test?