This repository has been archived by the owner on Nov 15, 2021. It is now read-only.
Update bootstrap script with new paths #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metachris
reviewed
Mar 19, 2018
neo/Prompt/Commands/Bootstrap.py
Outdated
| @@ -7,6 +7,9 @@ | |||
| import shutil | |||
| import os | |||
|
|
|||
| DEFAULT_TMP_BOOTSTRAP_FILE = os.path.join(settings.DATA_DIR_PATH, | |||
There was a problem hiding this comment.
Move this const into the function, because the settings data for might be changed using the --datadir argument, which would not be used like this
metachris
reviewed
Mar 19, 2018
neo/Prompt/Commands/Bootstrap.py
Outdated
|
|
||
| print("bootstrap cancelled") | ||
| sys.exit(0) | ||
|
|
||
|
|
||
| def do_bootstrap(bootstrap_file, destination_dir, tmp_file_name='./Chains/bootstrap.tar.gz', tmp_chain_name='tmpchain'): | ||
| def do_bootstrap(bootstrap_file, destination_dir, tmp_file_name=DEFAULT_TMP_BOOTSTRAP_FILE, tmp_chain_name='tmpchain'): |
There was a problem hiding this comment.
Could use None instead and then use the data dir
metachris
reviewed
Mar 19, 2018
| @@ -92,6 +99,7 @@ def do_bootstrap(bootstrap_file, destination_dir, tmp_file_name='./Chains/bootst | |||
| print("cleaning up %s " % tmp_chain_name) | |||
| if os.path.exists(tmp_chain_name): | |||
| shutil.rmtree(tmp_chain_name) | |||
| os.remove(tmp_file_name) | |||
There was a problem hiding this comment.
We might want to keep the downloaded file, for test bootstrap perhaps? Cc @localhuman
|
Thanks for contributing! 👍 Edit: please run |
dethos
force-pushed
the
bootstrap-user-data-dir
branch
from
4d37b8d
to
d16d893
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What current issue(s) does this address, or what feature is it adding?
#338 - With the new user data paths, the download of the bootstrap files are failing.
How did you solve this problem?
Removed the hard-coded relative paths in the bootstrap script and added dynamic user paths based on the new
DATA_DIR_PATH.How did you make sure your solution works?
Checked it manually. Downloaded the chains on my personal computer using these changes.
Are there any special changes in the code that we should be aware of?
Not really, I just added a call to
os.remove()on the downloaded file since it isn't removed and stays there wasting space.Please check the following, if applicable:
make lint?make test?CHANGELOG.rst? (if not, please do)