This repository has been archived by the owner on Nov 15, 2021. It is now read-only.
IsWalletTransaction fix #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What current issue(s) does this address, or what feature is it adding?
In IsWalletTransaction in neo/Wallets/Wallet.py, as part of evaluating whether a transaction belongs to a wallet or not, neo-python is currently comparing the VerificationScript to all the contract scripthashes in the wallet. However this will never return true, because a scripthash is by definition a hash of a script so it has already gone through the hashing process before the comparison, even if they were the same scripts to start with. As a result,
wallet verbosewas not showing the complete set of transactions for added contract addresses and watch-only addresses (outbound transactions were missing)How did you solve this problem?
Changed the comparisons to compare script to script for contracts, and scripthash to scripthash for watch_only addresses where we don't know what the original VerificationScript looks like.
How did you make sure your solution works?
Tested it manually on a local wallet
Are there any special changes in the code that we should be aware of?
No
Please check the following, if applicable:
make lint?make test?CHANGELOG.rst? (if not, please do)