Skip to content
This repository has been archived by the owner on Nov 15, 2021. It is now read-only.

Notification server updates #519

Merged
merged 1 commit into from Jul 21, 2018
Merged

Notification server updates #519

merged 1 commit into from Jul 21, 2018

Conversation

localhuman
Copy link
Collaborator

update notification endpoint to include total_pages in output, and allow pagesize paramater to be passed in. This brings the server in parallel with the C# notification implementation.

Also now page index starts at 1 rather than 0. Passing in page=0 will convert to page 1.

How did you solve this problem?

  • added total_pages value to output.

How did you make sure your solution works?

  • tests

Please check the following, if applicable:

  • Did you add any tests?
  • Did you run make lint?
  • Did you run make test?
  • Are you making a PR to a feature branch or development rather than master?
  • Did you add an entry to CHANGELOG.rst? (if not, please do)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 80.346% when pulling 43ba575 on notification-fixes into 19a786b on development.

@localhuman localhuman merged commit 58bae23 into development Jul 21, 2018
@localhuman localhuman deleted the notification-fixes branch July 21, 2018 17:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants