Skip to content
This repository has been archived by the owner on Nov 15, 2021. It is now read-only.

disallow writing amounts in SmartContractEvent which are greater than… #540

Merged
merged 1 commit into from Aug 9, 2018

Conversation

localhuman
Copy link
Collaborator

… ulong long max

What current issue(s) does this address, or what feature is it adding?

  • Someone is dispatching events with very strange amounts. This fix disallows trying to write an amount that is longer than ulong long max.

How did you make sure your solution works?

  • manual testing.

Are there any special changes in the code that we should be aware of?

Please check the following, if applicable:

  • Did you add any tests?
  • Did you run make lint?
  • Did you run make test?
  • Are you making a PR to a feature branch or development rather than master?
  • Did you add an entry to CHANGELOG.rst? (if not, please do)

This was referenced Aug 9, 2018
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.009%) to 80.17% when pulling 6348a73 on persist-fix into 56f3c41 on development.

@localhuman localhuman merged commit f1a5db6 into development Aug 9, 2018
@ixje ixje deleted the persist-fix branch October 2, 2018 18:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants