This repository has been archived by the owner on Nov 15, 2021. It is now read-only.
Nep8 #635
Merged
Nep8 #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Restore appending executed script hashes - apply AltStack replication fixes of neo-project/neo-vm@59f3e66
- fix CheckStackSize: neo-project/neo@e8c5e03 - fix CheckDynamicInvoke: neo-project/neo@b8ad89e and general update to checkstacksize as it was lagging behind
limit arraysize in 'block.gettransactions' neo-project/neo@9660630 limit itemsize in 'runtime_serialize' neo-project/neo@5894cbd
fix missed statement
add description for new stack isolation instructions
ixje
suggested changes
Sep 25, 2018
neo/Settings.py
Outdated
| @@ -203,6 +205,9 @@ def setup(self, config_file): | |||
| if 'ServiceEnabled' in config: | |||
| self.SERVICE_ENABLED = bool(config['ServiceEnabled']) | |||
|
|
|||
| if 'CompilerNep8' in config: | |||
| self.COMPILER_NEP_8 = bool(config['CompilerNep8']) | |||
There was a problem hiding this comment.
I'd like to suggest to at least use config.get('CompilerNep8', False) because the AcceptIncomingPeers update showed that quite some users just copy/replace their configs with their old one after they upgraded. Then this call will fail because the key is not there. Ideally we might want to have a utility function that tries to get the key, if not uses a specified default value but also warns the user that the key was not found and is now using the "x" as the default.
ixje
approved these changes
Sep 26, 2018
|
🥇 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What current issue(s) does this address, or what feature is it adding?
This addresses #585, and supersedes #603. It adds in NEP8 functionality from here: CityOfZion/neo-boa#94
Also makes usage of NEP8 compiler features configurable via
protocol.jsonand from the prompt, with the default value beingFalseuntil NEP8 is on mainnet. From the prompt, you can useconfig compiler-nep8 on|offHow did you solve this problem?
How did you make sure your solution works?
Are there any special changes in the code that we should be aware of?
Please check the following, if applicable:
make lint?make test?CHANGELOG.rst? (if not, please do)