Skip to content
This repository has been archived by the owner on Nov 15, 2021. It is now read-only.

Add sendfrom and sendmany RPC methods #640

Merged
merged 14 commits into from Sep 30, 2018

Conversation

jseagrave21
Copy link
Contributor

What current issue(s) does this address, or what feature is it adding?

  • Adds sendfrom RPC method and tests
  • Adds sendmany RPC method and tests (original sendmany PR from here: Add sendmany RPC method #596)
  • Integrates both methods with sendtoaddress RPC method

Helps address issue #189 and CityOfZion/neo-python-rpc#12

NOTE: This PR was re-created from #588

How did you solve this problem?
Worked from #556 and adjusted accordingly

NOTE: This PR relies on BlockchainFixtureTestCase through WalletFixtureTestCase

How did you make sure your solution works?
Unittest

Are there any special changes in the code that we should be aware of?
No

Please check the following, if applicable:

  • Did you add any tests?
  • Did you run make lint?
  • Did you run make test?
  • Are you making a PR to a feature branch or development rather than master?
  • Did you add an entry to CHANGELOG.rst? (if not, please do)

Merge CoZ Development into jseagrave21 Development
Merge CoZ Development into jseagrave21 Development
Merge CoZ development into jseagrave21 development
Merge CoZ Development into jseagrave21 Development
Merge CoZ Development into jseagrave21 development
Merge CoZ Development into jseagrave21 development
Merge CoZ Development into jseagrave21 development
Merge CoZ Development with jseagrave21 development
@ixje
Copy link
Member

ixje commented Sep 30, 2018

💯
once again thanks for all the work

@ixje ixje merged commit 1d12e1d into CityOfZion:development Sep 30, 2018
@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 79.641% when pulling 9e3ab0b on jseagrave21:sendfrom-and-sendmany into d062ac7 on CityOfZion:development.

@jseagrave21 jseagrave21 deleted the sendfrom-and-sendmany branch September 30, 2018 18:26
@jseagrave21
Copy link
Contributor Author

@ixje 👍 Thank you for your help and effective reviews!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants