Skip to content
This repository has been archived by the owner on Nov 15, 2021. It is now read-only.

revert nodemanager.start.port #948

Merged
merged 3 commits into from
May 30, 2019

Conversation

jseagrave21
Copy link
Contributor

@jseagrave21 jseagrave21 commented May 30, 2019

What current issue(s) does this address, or what feature is it adding?

How did you solve this problem?

  • now points to settings.NODE_PORT instead of 8888

How did you make sure your solution works?
manual testing

Are there any special changes in the code that we should be aware of?
no

Please check the following, if applicable:

  • Did you add any tests?
  • Did you run make lint?
  • Did you run make test?
  • Are you making a PR to a feature branch or development rather than master?
  • Did you add an entry to CHANGELOG.rst? (if not, please do)

jseagrave21 added 2 commits May 29, 2019 22:56
- now points to `settings.NODE_PORT` instead of set to 8888
@coveralls
Copy link

coveralls commented May 30, 2019

Coverage Status

Coverage increased (+0.001%) to 85.052% when pulling 6b3d4fa on jseagrave21:fix-nodemanager-start-port into c95fec6 on CityOfZion:development.

@ixje
Copy link
Member

ixje commented May 30, 2019

I removed the changelog entry. This is so small (and actually a regression issue that's not out there in any release) that I consider it not big enough to report in the changelog. Still good catch!

@ixje ixje merged commit e32fcaf into CityOfZion:development May 30, 2019
@jseagrave21 jseagrave21 deleted the fix-nodemanager-start-port branch May 30, 2019 10:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants