This repository has been archived by the owner on Nov 15, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What current issue(s) does this address, or what feature is it adding?
if the nodemanager port is already in use (e.g. due to running a private net on the same port) then we will abort and shutdown. However,
shutdown()
can be called before all tasks have been started. Theasyncio.gather
will receiveNone
type instead of a task which will throw an exception.How did you solve this problem?
sanity check that a task exists before adding it to list of tasks we wait for during shutdown.
How did you make sure your solution works?
manually testing
Are there any special changes in the code that we should be aware of?
Please check the following, if applicable:
make lint
?make test
?CHANGELOG.rst
? (if not, please do)