Skip to content
This repository has been archived by the owner on Nov 15, 2021. It is now read-only.

Fix shutdown exc #955

Merged
merged 3 commits into from
Jun 5, 2019
Merged

Fix shutdown exc #955

merged 3 commits into from
Jun 5, 2019

Conversation

ixje
Copy link
Member

@ixje ixje commented Jun 5, 2019

What current issue(s) does this address, or what feature is it adding?
if the nodemanager port is already in use (e.g. due to running a private net on the same port) then we will abort and shutdown. However, shutdown() can be called before all tasks have been started. The asyncio.gather will receive None type instead of a task which will throw an exception.

How did you solve this problem?
sanity check that a task exists before adding it to list of tasks we wait for during shutdown.

How did you make sure your solution works?
manually testing

Are there any special changes in the code that we should be aware of?

Please check the following, if applicable:

  • Did you add any tests?
  • Did you run make lint?
  • [] Did you run make test?
  • Are you making a PR to a feature branch or development rather than master?
  • Did you add an entry to CHANGELOG.rst? (if not, please do)

@coveralls
Copy link

coveralls commented Jun 5, 2019

Coverage Status

Coverage increased (+0.002%) to 85.123% when pulling 979c2e4 on ixje:fix-shutdown-exc into d61452a on CityOfZion:development.

@ixje ixje merged commit d2362d4 into CityOfZion:development Jun 5, 2019
@ixje ixje deleted the fix-shutdown-exc branch June 5, 2019 10:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants