This repository has been archived by the owner on Nov 15, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What current issue(s) does this address, or what feature is it adding?
when running sc invocations via e.g. the
build_run
command we parse the smart contract parameters from the console. Specifically list arguments were trouble some. TakeThe old logic would parse
['aa']
into a BigInteger becauseneo-python/neo/Prompt/Commands/Invoke.py
Line 509 in d2362d4
would turn
['aa']
into[b'6161']
because it uses recursion internally.Then when we continue we parse the items again in which
neo-python/neo/Prompt/Commands/Invoke.py
Lines 510 to 514 in d2362d4
which now tries to parse
[b'6161']
and that will happily be picked up atneo-python/neo/Prompt/Utils.py
Lines 232 to 235 in d2362d4
and now we have a
BigInteger
we do not want.How did you solve this problem?
the quick fix was to remove the recursion from list parsing. The downside this limits how many lists can be nested. The upside is it is fast. We should redo the whole prompt parsing and script builder for neo-python 3.0
How did you make sure your solution works?
manual testing
Are there any special changes in the code that we should be aware of?
Please check the following, if applicable:
make lint
?make test
?CHANGELOG.rst
? (if not, please do)