This repository has been archived by the owner on Nov 15, 2021. It is now read-only.
fix BigInteger.ToByteArray() for certain negative values #963
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What current issue(s) does this address, or what feature is it adding?
the audit of testnet block
678752
showed a storage deviation caused by a difference in return value for theBigInteger.ToByteArray()
method for the number-48335248028225339427907476932896373492484053930
How did you solve this problem?
glanced at the C# source of the
BigInteger
class and applied somewhat similar logicHow did you make sure your solution works?
test cases + audit now passes for the block
Are there any special changes in the code that we should be aware of?
Please check the following, if applicable:
make lint
?make test
?CHANGELOG.rst
? (if not, please do)