Skip to content
This repository has been archived by the owner on Nov 15, 2021. It is now read-only.

Workaround neo-cli accepting invalid contract parameter types #968

Merged
merged 1 commit into from
Jun 13, 2019
Merged

Workaround neo-cli accepting invalid contract parameter types #968

merged 1 commit into from
Jun 13, 2019

Conversation

ixje
Copy link
Member

@ixje ixje commented Jun 13, 2019

What current issue(s) does this address, or what feature is it adding?
audit of testnet block 846536 showed a deviating in VMstate due to the syscall Neo.Contract.Create accepting invalid ContractParameterType's whereas neo-python throwed exceptions. The issue is reported there: neo-project/neo#827

How did you solve this problem?
added a workaround to be inline with neo-cli, but should be fixed in neo-cli

How did you make sure your solution works?
audit passes, make test

Are there any special changes in the code that we should be aware of?
na/

Please check the following, if applicable:

  • Did you add any tests?
  • Did you run make lint?
  • Did you run make test?
  • Are you making a PR to a feature branch or development rather than master?
  • Did you add an entry to CHANGELOG.rst? (if not, please do)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.009%) to 85.904% when pulling c416897 on ixje:tmp-fix-invalid-contract-param into 366cb0c on CityOfZion:development.

@ixje ixje merged commit 4cff419 into CityOfZion:development Jun 13, 2019
@ixje ixje deleted the tmp-fix-invalid-contract-param branch June 13, 2019 10:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants