Skip to content
This repository has been archived by the owner on Nov 15, 2021. It is now read-only.

fix Array.GetBoolean() #977

Merged
merged 1 commit into from Jul 8, 2019
Merged

fix Array.GetBoolean() #977

merged 1 commit into from Jul 8, 2019

Conversation

ixje
Copy link
Member

@ixje ixje commented Jul 8, 2019

What current issue(s) does this address, or what feature is it adding?
audit of testnet block 1532382 showed a deviation in gas consumption due to a different return value for the GetBoolean() call of the Array stack item.

How did you solve this problem?
bring inline with changes to C#

How did you make sure your solution works?
audit passes, make test

Are there any special changes in the code that we should be aware of?

Please check the following, if applicable:

  • Did you add any tests?
  • Did you run make lint?
  • Did you run make test?
  • Are you making a PR to a feature branch or development rather than master?
  • Did you add an entry to CHANGELOG.rst? (if not, please do)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 85.284% when pulling 96995c3 on ixje:fix-array-stackitem into f5dd427 on CityOfZion:development.

@ixje ixje merged commit 79f43a8 into CityOfZion:development Jul 8, 2019
@ixje ixje deleted the fix-array-stackitem branch July 8, 2019 08:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants