Skip to content
This repository has been archived by the owner on Nov 15, 2021. It is now read-only.

Add raw tx functionality #981

Merged
merged 30 commits into from
Jul 15, 2019
Merged

Conversation

jseagrave21
Copy link
Contributor

@jseagrave21 jseagrave21 commented Jul 10, 2019

What current issue(s) does this address, or what feature is it adding?
Currently, the RawTransaction class which is in development to address issue #886 cannot function after introduction of a mandatory snapshot variable.
Please refer to this review/discussion: #974 (review)

How did you solve this problem?

  • makes snapshot optional for Transaction.GetScriptHashesForVerifying
  • adds necessary logic to ContractParametersContext

How did you make sure your solution works?
manual testing

Are there any special changes in the code that we should be aware of?
See above

Please check the following, if applicable:

  • Did you add any tests?
  • Did you run make lint?
  • Did you run make test?
  • Are you making a PR to a feature branch or development rather than master?
  • Did you add an entry to CHANGELOG.rst? (if not, please do)

jseagrave21 and others added 28 commits October 9, 2018 20:38
Merge CoZ Development into jseagrave21 Development
Merge CoZ Development into jseagrave21 Development
Merge CoZ Development into jseagrave21 Development
* Update ExtendedJsonRpcApi.py

- add fix provided by @localhuman so original methods are returned as well as extended methods
…yOfZion#661)

* Add the option -u (unittest-net) to prompt.py

* Add unittest guildeline and add the smart contract source codes (UnitTest-SM.zip) to the fixtures package
for compatibility
* Fix ExtendedJsonRpcApi (CityOfZion#662)

* Update ExtendedJsonRpcApi.py

- add fix provided by @localhuman so original methods are returned as well as extended methods

* Mute expected test stacktrace and clearly identify why an exception is thrown. (CityOfZion#663)

* Add guideline for adding tests to the neo-privnet-unittest image (CityOfZion#661)

* Add the option -u (unittest-net) to prompt.py

* Add unittest guildeline and add the smart contract source codes (UnitTest-SM.zip) to the fixtures package

* Add raw transaction building examples (CityOfZion#665)

* Update neo-boa version to fix core building test
Merge CoZ Development into jseagrave21 Development
Merge CoZ Development into jseagrave21 Development
Merge CoZ Development into jseagrave21 Development
Merge CoZ Development into jseagrave21 development
Merge CoZ development into jseagrave21 development
- add tests for "showallaccounts" and "showallaccountstates"
Merge neo-python development into jseagrave21 development
Merge neo-python development into jseagrave21 development
Merge neo-python development into jseagrave21 development
Merge CoZ development into jseagrave21 development
Gracefully handle NEP-5 balance query failures (CityOfZion#744)
Merge CoZ development into neo-python development
Merge CoZ development into jseagrave21 development
Merge CoZ Development into jseagrave21 development
Merge CoZ/neo-python development into jseagrave21/neo-python development
- makes snapshot optional for Transaction.GetScriptHashesForVerifying
- adds necessary logic to ContractParametersContext
@jseagrave21 jseagrave21 mentioned this pull request Jul 10, 2019
4 tasks
@coveralls
Copy link

coveralls commented Jul 10, 2019

Coverage Status

Coverage decreased (-0.005%) to 85.288% when pulling 915f841 on jseagrave21:raw_tx-functionality into 467c3ea on CityOfZion:development.

@ixje ixje merged commit c06df37 into CityOfZion:development Jul 15, 2019
@jseagrave21 jseagrave21 deleted the raw_tx-functionality branch September 21, 2019 15:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants