This repository has been archived by the owner on Nov 15, 2021. It is now read-only.
Auto-Delete Bootstrap File #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 16, 2019 09:50
* Updated the `np-bootstrap` process so that it will delete the downloaded bootstrap file by default when it's done. * Added a `-k`/`--keep-bootstrap-file` flag to `np-bootstrap` to allow you to keep the bootstrap file in case you need to re-use the file after download.
* Added the PR link to the changelog.
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What current issue(s) does this address, or what feature is it adding?
Auto-delete the downloaded bootstrap file after running
np-bootstrap.How did you solve this problem?
np-bootstrapprocess so that it will delete the downloaded bootstrap file by default when it's done.-k/--keep-bootstrap-fileflag tonp-bootstrapto allow you to keep the bootstrap file in case you need to re-use the file after download.How did you make sure your solution works?
Tested it with both configurations.
Are there any special changes in the code that we should be aware of?
No.
Please check the following, if applicable:
make lint?make test?CHANGELOG.rst? (if not, please do)