Skip to content
This repository has been archived by the owner on Nov 15, 2021. It is now read-only.

fix stack item deserialization for Boolean VM type #994

Merged
merged 1 commit into from
Jul 25, 2019
Merged

fix stack item deserialization for Boolean VM type #994

merged 1 commit into from
Jul 25, 2019

Conversation

ixje
Copy link
Member

@ixje ixje commented Jul 25, 2019

What current issue(s) does this address, or what feature is it adding?
audit of testnet block 2591458 showed a deviation in storage value due to wrong a deserialization of a Boolean VM type. This was caused by the Boolean type receiving an integer as value as opposed to a bool type. This resulted in deserializing the value 44 as opposed to True, leading to a 0x01 0x2c instead of 0x01 0x01.

How did you solve this problem?
convert int to bool for stack item deserialization

How did you make sure your solution works?
audit of block passes

Are there any special changes in the code that we should be aware of?

Please check the following, if applicable:

  • Did you add any tests?
  • Did you run make lint?
  • Did you run make test?
  • Are you making a PR to a feature branch or development rather than master?
  • Did you add an entry to CHANGELOG.rst? (if not, please do)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 85.28% when pulling 2af702e on ixje:fix-boolean-type into a350388 on CityOfZion:development.

@ixje ixje merged commit 5881205 into CityOfZion:development Jul 25, 2019
@ixje ixje deleted the fix-boolean-type branch July 25, 2019 09:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants