This repository has been archived by the owner on Nov 15, 2021. It is now read-only.
fix stack item deserialization for Boolean VM type #994
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What current issue(s) does this address, or what feature is it adding?
audit of testnet block
2591458
showed a deviation in storage value due to wrong a deserialization of a Boolean VM type. This was caused by the Boolean type receiving aninteger
as value as opposed to abool
type. This resulted in deserializing the value44
as opposed toTrue
, leading to a0x01 0x2c
instead of0x01 0x01
.How did you solve this problem?
convert int to bool for stack item deserialization
How did you make sure your solution works?
audit of block passes
Are there any special changes in the code that we should be aware of?
Please check the following, if applicable:
make lint
?make test
?CHANGELOG.rst
? (if not, please do)