Skip to content
This repository has been archived by the owner on Nov 15, 2021. It is now read-only.

use snapshot for ED/EDT validation #998

Merged
merged 1 commit into from
Jul 31, 2019
Merged

use snapshot for ED/EDT validation #998

merged 1 commit into from
Jul 31, 2019

Conversation

ixje
Copy link
Member

@ixje ixje commented Jul 31, 2019

What current issue(s) does this address, or what feature is it adding?
audit of testnet block 2842737 showed a deviation in VM state due to not using snapshots for CALL_ED/EDT dynamic invoke validation. This should have been part of #995

How did you solve this problem?
use same logic as #995

How did you make sure your solution works?
audit of block passes

Are there any special changes in the code that we should be aware of?

Please check the following, if applicable:

  • Did you add any tests?
  • Did you run make lint?
  • Did you run make test?
  • Are you making a PR to a feature branch or development rather than master?
  • Did you add an entry to CHANGELOG.rst? (if not, please do)

@ixje ixje merged commit 338189c into CityOfZion:development Jul 31, 2019
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.004%) to 85.263% when pulling 73f73ab on ixje:check-dynamic-2 into a7993c2 on CityOfZion:development.

@ixje ixje deleted the check-dynamic-2 branch September 9, 2019 06:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants