Skip to content
This repository has been archived by the owner on Apr 6, 2020. It is now read-only.

delete account on prompt #202

Merged
merged 1 commit into from
Jul 11, 2018
Merged

Conversation

melanke
Copy link
Contributor

@melanke melanke commented Jul 11, 2018

No description provided.

@codecov
Copy link

codecov bot commented Jul 11, 2018

Codecov Report

Merging #202 into development will increase coverage by 0.32%.
The diff coverage is 50%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #202      +/-   ##
===============================================
+ Coverage        40.71%   41.04%   +0.32%     
===============================================
  Files              227      227              
  Lines             8534     8540       +6     
===============================================
+ Hits              3475     3505      +30     
+ Misses            5059     5035      -24
Impacted Files Coverage Δ
src/NeoSharp.Application/Client/Prompt[Wallet].cs 0% <0%> (ø) ⬆️
src/NeoSharp.Core/Wallet/NEP6/NEP6WalletManager.cs 78.52% <100%> (+1.17%) ⬆️
src/NeoSharp.Core/Wallet/NEP6/NEP6Account.cs 86.36% <0%> (+13.63%) ⬆️
src/NeoSharp.Core/Models/Contract.cs 55.55% <0%> (+33.33%) ⬆️
src/NeoSharp.Core/Converters/UInt160Converter.cs 76.74% <0%> (+41.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70aba97...cb497bb. Read the comment docs.

.gitignore Outdated
@@ -259,3 +259,4 @@ paket-files/

PublishProfiles
src/NeoSharp.Application/Properties/launchSettings.json
src/NeoSharp.Application/localhost
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should solve this problem with your Working directory

@@ -61,6 +62,12 @@ private void AccountCreateCommand()
var secureString = _consoleReader.ReadPassword();
_walletManager.CreateAccount(secureString);
}

[PromptCommand("account delete", Category = "Account", Help = "Deletes an account")]
private void AccountDeleteCommand(string scriptHash)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UInt160 ?

/// Remove the account.
/// </summary>
/// <param name="scriptHash">Scripthash's account.</param>
void DeleteAccount(string scriptHash);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UInt160

/// Remove the account.
/// </summary>
/// <param name="scriptHash">Scripthash's account.</param>
public void DeleteAccount(string scriptHash)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UInt160

var mockWalletManager = GetAWalletManagerWithAnWallet();

// Act
IWalletAccount walletAccount = mockWalletManager.CreateAccount(_defaultPassword);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

var

@shargon shargon merged commit c57183d into CityOfZion:development Jul 11, 2018
@lock9 lock9 deleted the deleteaccount branch September 24, 2018 03:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants