This repository has been archived by the owner on Apr 6, 2020. It is now read-only.
Make BlockProcessor with less dependencies #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…terface but it's not anymore, threfore should not carry the prefix "I" that identify the interfaces.
…into development
…into development
…into development
Black listed peers try to connect test
…ge of the method RandomInt. * Small clean up on the UtCrypto
more tests will be added soon!
…into development
…into development
…into development
…into development
…into development
…into development
…into development
…into development
…into development
* Fix an inverted if logic. The code only enter in the While loop if the cancellation was requested and should be the other way around.
…into development
…into development
…into development
…into development
…into development
…into development
…ble and immutable). The intenstion of this refactor is to bring better readability of the code and remove logic code from the DTO.
This reverts commit 34c676a.
…esposable to Sign and Verify the block and the witness
…itness. Transaction, BlockHeader and Block OperationManager classes. In this classes the verify method will be implemented. CityOfZion#306, CityOfZion#307
…into development
…into development
…appen when the node start without genesis block.
…into development
…nces. BlockProcessor use only Block object. CityOfZion#350, CityOfZion#351
…into development
…de in a clean environment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According with issue #350, BlockProcessor has now less dependencies and with less "moving parts" to be considered.
Direct interaction of the BlockProcessor is with BlockPool and BlockPersister and no more reference to the BlockHeader that is now take care inside the BlockPersister.
This change is pushing down the treatment of the Block and BlockHeader as low as possible, close to the persistence implementation as described in the #351