This repository has been archived by the owner on Apr 6, 2020. It is now read-only.
Travis deploy docker images rewritten new auth with env vars #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… possible to compile the Node using source from master or development branch
…into development
daily commit from CoZ
Updated README.md to have the Node Interaction Diagram and removed tr…
origin sync
…into development
This reverts commit baa376e.
…into development
Update NullStackItemsStack.cs
Complete implementation of RedisDbJsonRepository and its Unit Tests. …
docker compose to run node with neo-private-network
fix peers to point to default neo-privnet peers
Integrate local-faucet in the multi-container ecosystem
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to put back the docker push functionality but using env vars inside the travis.yml instead of the repository setting panel.
It was clear that this way is secure as we can read below:
$ echo "Test Success - Branch($TRAVIS_BRANCH) Pull Request($TRAVIS_PULL_REQUEST) Tag($TRAVIS_TAG)" Test Success - Branch(travis-deploy-rewritten-new-auth) Pull Request(false) Tag()if
$TRAVIS_PULL_REQUESTis false we are safehttps://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
"Travis CI makes encrypted variables and data available only to pull requests coming from the same repository. These are considered trustworthy, as only members with write access to the repository can send them.
Pull requests sent from forked repositories do not have access to encrypted variables or data."