Skip to content
This repository has been archived by the owner on Apr 6, 2020. It is now read-only.

Fix #306 and Fix #362 #430

Merged
merged 1 commit into from Sep 24, 2018

Conversation

melanke
Copy link
Contributor

@melanke melanke commented Sep 21, 2018

Before merging this, I have 2 questions:

  • Should we check for asset.Expiration <= _blockchain.Height + 1 ??
  • Neo's current implementation is not verifying Receiving Scripts, it's commented, I also didn't verify.

@aboimpinto
Copy link
Contributor

Missing the test for the verification of the transaction. The test should document the behavior and make sure that is working as expected.

@melanke
Copy link
Contributor Author

melanke commented Sep 21, 2018

@aboimpinto
Copy link
Contributor

sorry ... my bad.
For some reason the GitHub User Interface wasn't load the file to because is too big ...

I didn't check test by test, we can see on the CodeCov how this method is cover

@osmirnov osmirnov merged commit ac79103 into CityOfZion:development Sep 24, 2018
@lock9 lock9 deleted the verify_transaction branch October 29, 2018 14:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants