Improve execution time of unit tests #1018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meevee98
force-pushed
the
CU-864dxrw5k
branch
4 times, most recently
from
bde7372
to
56fd3ed
Compare
…mes were passed incorrectly
luc10921
reviewed
Apr 11, 2023
| @@ -178,25 +188,53 @@ def get_contract_path(self, *args: str) -> str: | |||
| raise FileNotFoundError(path) | |||
| return path | |||
|
|
|||
| def get_deploy_file_paths_without_compiling(self, contract_path: str) -> Tuple[str, str]: | |||
| file_path_without_ext, _ = os.path.splitext(contract_path) | |||
| if USE_UNIQUE_NAME: | |||
There was a problem hiding this comment.
Why use USE_UNIQUE_NAME instead of self._use_custom_name?
Also, other files are always using engine.use_contract_custom_name = self._use_custom_name. Does USE_UNIQUE_NAME only exist to be more explicit?
There was a problem hiding this comment.
self._use_custom_name was included in BoaTest to pass its value to the tests using TestEngine without having to import the USE_UNIQUE_NAME constant across all the test files, it'll be removed when we remove TestEngine as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.