Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated smart contract used to test manifest generation #1121

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

luc10921
Copy link
Collaborator

Summary or solution description
Some contracts were testing different things, but the smart contract was the same.

  • Merged MetadataInfoNameDefault.py, MetadataInfoGroupDefault.py, MetadataInfoPermissionsDefault.py, MetadataInfoSourceDefault.py, and MetadataInfoTrustsDefault.py into one contract;
  • Changed Nep17Interface.py to have methods with camelCase and kept the Nep17InterfaceWithDisplayName.py file.

Platform:

  • OS: Windows 10 x64
  • Python version: Python 3.7

@luc10921 luc10921 requested a review from melanke August 24, 2023 21:36
@luc10921 luc10921 self-assigned this Aug 24, 2023
@lllwvlvwlll
Copy link
Member

@coveralls
Copy link
Collaborator

coveralls commented Aug 24, 2023

Coverage Status

coverage: 91.955%. remained the same when pulling 2b0299b on CU-864evbhp0 into 7072a31 on development.

@melanke melanke merged commit 8eba358 into development Aug 25, 2023
6 checks passed
@melanke melanke deleted the CU-864evbhp0 branch August 25, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants