Refactor test_for.py to use BoaTestConstructor #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meevee98
reviewed
Jan 3, 2024
| default_folder: str = 'test_sc/for_test' | ||
|
|
||
| def test_for_tuple_condition(self): | ||
| async def test_for_tuple_condition(self): |
There was a problem hiding this comment.
Can you break the tests that test both the compilation and execution in two different test cases?
This one for example, into test_for_tuple_condition_compile and test_for_tuple_condition_run
I'm commenting only in this one, but the suggestion is for all test cases that are testing both the compilation and execution
meevee98
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary or solution description
Started using
BoaTestCaseonTestForPlatform: