Using byte lengths instead of hexstring lengths #101
Conversation
src/utils.js
Outdated
| if (typeof num !== 'number') throw new Error('num must be numeric') | ||
| if (num < 0) throw new RangeError('num is unsigned (>= 0)') | ||
| size = size * 2 | ||
| if (size % 2 !== 0) throw new RangeError('size must be a multiple of 2') |
There was a problem hiding this comment.
i think the error msg should be about it being an integer. If it is an integer, it will always be multiple of 2 as you multipled it by 2.
There was a problem hiding this comment.
Good point, it's essentially acting as an integer check there. I'll change that check/message
There was a problem hiding this comment.
mm the rest looks good, will merge once i see this change
notatestuser
force-pushed
the
feature/byte-lengths
branch
2 times, most recently
from
e1401db
to
94c8296
Compare
notatestuser
force-pushed
the
feature/byte-lengths
branch
from
94c8296
to
2e5142d
Compare
|
Should be careful with this change if we think dependent apps might be consuming the utils directly. |
|
good point. will ask around. v3? ugh dont feel like i should be jumping the majors so fast hahaaha |
|
If we're following semantic versioning then yeah it should be v3 since those functions were exported. However now that everyone uses a lockfile with npm/yarn nowadays and because this is technically still just the library for neon-wallet a minor jump could be okay imo. |
As discussed in #80