Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix variable name #363

Merged
merged 1 commit into from
Dec 4, 2018
Merged

Fix variable name #363

merged 1 commit into from
Dec 4, 2018

Conversation

corollari
Copy link
Contributor

'neon-js' is illegal as a variable name in JavaScript because dashes ('-') are not allowed in variable names. This results in an error when executing the script.
This PR fixes the variable name by replacing the dash with an underscore.

@snowypowers
Copy link
Member

Hi I would prefer to use neonJs over underscores to keep everything else consistent. Most of the codebase is running camelCase.

Thanks for noticing and contributing!

@corollari
Copy link
Contributor Author

corollari commented Nov 28, 2018 via email

'neon-js' is illegal as a variable name in JavaScript because dashes ('-') are not allowed in variable names. This results in an error when executing the script
@snowypowers snowypowers changed the base branch from master to dev December 4, 2018 09:31
@snowypowers snowypowers merged commit f2726fb into CityOfZion:dev Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants