fix(wallet): resolve slow scrypt encryption/decryption with react #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there really a speed difference? Just looking at the test runtimes (this PR and an older run ), the runtimes are very similar. I am not opposed to using ethereum's package since its more modern & supported but calling it a fix without any stats is not ideal. Do you have any runtime numbers? How about pitching this as a "modernization" instead of a true speed fix? |
|
The test cases indeed do not show much if any difference. The difference is there when used in combination with React. If you check the issue you’ll see a discussion including some code playgrounds where we get very high delays. With this package, in the specific problematic scenario, the speed difference goes from ~13 seconds to sub 1 second.On 15 Apr 2023, at 06:00, Yak Jun Xiang ***@***.***> wrote:
Is there really a speed difference? Just looking at the test runtimes (this PR and an older run, the runtimes are very similar.
I am not opposed to using ethereum's package since its more modern & supported but calling it a fix without any stats is not ideal. Do you have any runtime numbers? How about pitching this as a "modernization" instead of a true speed fix?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
snowypowers
approved these changes
Apr 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #891
I can't explain the difference between packages, I just know there is a speed difference despite both being pure-js.
I've considered
hash-wasmas alternative toethereum-cryptography, but it was actually slower and required more changes.