Shape to geojson #51
Merged
Shape to geojson #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use shapely.geomtery.mapping to convert shapely geomtry objects to geojson dicts, dropping geopandas dependency.
ezheidtmann
reviewed
Dec 12, 2018
| if isinstance(shape, Point) and "bbox" in feature: | ||
| del feature["bbox"] | ||
| if isinstance(shape, Point): | ||
| feature["coordinates"] = list(feature["coordinates"]) |
There was a problem hiding this comment.
curious -- why is it important that the results are python lists rather than tuples?
There was a problem hiding this comment.
@johnclary want to chime in with any thoughts?
@ezheidtmann is there a performance or other consideration we should be aware of here? The only thing that comes to my mind is the schema validation - will a tuple pass where a list does currently? I don't know.
There was a problem hiding this comment.
Tuples and lists are equivalent after they've been serialized to JSON, so hopefully jsonschema doesn't care. Generally tuples use less memory but I ask because if tuples are acceptable, this function becomes a lot simpler.
thekaveman
added a commit
that referenced
this pull request
Dec 31, 2018
* Convert shapely to geojson dict * minor import cleanups * removing geopandas install_requires
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New version of #48.
Closes #47.