Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy tables comments in replicator DAGs #787

Merged
merged 4 commits into from
Dec 4, 2023
Merged

Copy tables comments in replicator DAGs #787

merged 4 commits into from
Dec 4, 2023

Conversation

tahaislam
Copy link
Contributor

What this pull request accomplishes:

  • Copy comments on tables while copying the actual contents in replicator DAGs
  • Specify which table failed to get copied in the Slack notification

Issue(s) this solves:

What, in particular, needs to reviewed:

  • An added sql query to copy_table
  • An extra option to send the extra failure message

What needs to be done by a sysadmin after this PR is merged

  • Deploy into data_scripts

@tahaislam tahaislam self-assigned this Dec 1, 2023
gabrielwol
gabrielwol approved these changes Dec 1, 2023
View reviewed changes
Copy link
Collaborator

@gabrielwol gabrielwol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! That extra_msg_from_task will be useful. I'll adapt the other PR I sent you to make use of this once it's merged.

dags/common_tasks.py Show resolved Hide resolved
@gabrielwol gabrielwol mentioned this pull request Dec 1, 2023
Merged
@tahaislam tahaislam merged commit 8f99bfe into master Dec 4, 2023
4 checks passed
@tahaislam tahaislam deleted the feat/copy_tables_comments branch December 4, 2023 20:18
@gabrielwol gabrielwol mentioned this pull request Apr 18, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrielwol gabrielwol gabrielwol approved these changes

Assignees

@tahaislam tahaislam

Labels
collisions enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Copy tables comments in replicator DAGs
2 participants
@tahaislam @gabrielwol