Name changes dont work if an account with the same name already joined and the name is 16 chars long

[IceCarim]

Hi, I am writing this on behalf of my friend, BrickWall_Gaming. He is unable to login because the server seems to detect his username as 17 characters even though his username is exactly 16 characters long. I have attached below the error message that he receives upon trying to login. Thank you in advance for your help.

[wingzero54]

We were talking via modmail on the subreddit but they stopped responding. When is this from? Have they tried to login since the original problem took place on 9/29 ?

[IceCarim]

We were talking via modmail on the subreddit but they stopped responding.
He mentioned that he managed to get ahold of LordOfMarzipan on Discord and therefore pursued the matter there instead of continuing the discussion over modmail.

When is this from?
The issue appears to have started on 9/29 or thereabouts. It is still persisting.

Have they tried to login since the original problem took place on 9/29?
Yes, and he is experiencing the same problem.

[Maxopoly]

The stored procedure here https://github.com/CivClassic/NameLayer/blob/master/namelayer-spigot/src/main/java/vg/civcraft/mc/namelayer/database/AssociationList.java#L44 doesn't properly cut off 16 character names to append a 1 if the name already exists. Gonna look into it later today

[IceCarim]

Awesome, thanks a lot.

[wingzero54]

Max did you have a chance to look into this some more?

[IceCarim]

I just wanted to follow up on this issue since it's been a while. I'd highly appreciate if anyone could help in fixing it, although I acknowledge that there's an inundation of other issues that need to be resolved. My friends and I are excitedly awaiting a fix so that we can all finally play together again; in a sense that would be like a Christmas present.

In any case, I don't intend to be unduly forceful - I know development is hard work and I appreciate the effort that goes into maintaining the server. If anyone can resolve this issue, I'd be extremely thankful.

[Maxopoly]

The underlying issue here is a bit more complicated, but I did a manual fix for your friends account specifically, lmk if it does not work.

[IceCarim]

I can confirm that the fix works and I highly appreciate it. Thanks for the Christmas present and a Merry Christmas to you. I'll let you close the issue at your discretion because while a fix for this specific case was rendered, perhaps the underlying issue should remain documented.