Fix portal hack not triggering #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you are falling really fast, you will be falling multiple blocks per second, and could possibly pass straight through an end portal. This fix changes the hack to use an event triggered earlier to detect if a player passes through an end portal.
|
Build Successful! You can find a link to the downloadable artifact below.
|
Comment on lines
+64
to
72
| public void onTick(ServerTickEndEvent event) { | ||
| for (Map.Entry<Player, Location> entry : teleports.entrySet()) { | ||
| entry.getKey().teleport(entry.getValue(), PlayerTeleportEvent.TeleportCause.END_PORTAL); | ||
| if (entry.getValue().getWorld().getName().equals(targetWorld)) { | ||
| spawnExit(entry.getValue()); | ||
| } | ||
| } | ||
| teleports.clear(); | ||
| } |
There was a problem hiding this comment.
Is it ever possible that this event can be fired simultaneously, such as during low TPS? If so I could imagine it causing some problems, and potentially more players falling through portals than before.
There was a problem hiding this comment.
Simultaneously with what? It runs at the end of a tick.
RedDevel2
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you are falling really fast, you will be falling multiple blocks per second, and could possibly pass straight through an end portal. This fix changes the hack to use an event triggered earlier to detect if a player passes through an end portal.