Fix chunk meta not saving #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okx-code
force-pushed
the
fix-chunk-meta
branch
from
0dbbdfa
to
156597b
Compare
|
Build Successful! You can find a link to the downloadable artifact below.
|
AngrySoundTech
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a race condition that casues chunk meta to not save chunks while they are loaded. The problem is that in the
insertmethod, a ConcurrentModificationException can be triggered, as the list may also be modified from the main thread, which prevents saving. This was partially fixed in #390 which will keep the executor running even when an exception is thrown, whereas before the executor would just never run again. This is a more permanent fix.