-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove PsuedoServer #552
base: main
Are you sure you want to change the base?
Remove PsuedoServer #552
Conversation
It's annoying to maintain and not actually necessary
Build Successful! You can find a link to the downloadable artifact below.
|
It's only "not actually necessary" because the tests that need it have been commented out. If you uncomment them, you'll see why it's necessary, but PseudoServer actually needs to be updated, which is why drafted #393. |
Perhaps a better solution would be moving it over to the test source set. It's otherwise just taking up space in the production jar when nothing other than the [commented out] tests need it. |
I'm not extending internal Bukkit classes |
FakePlayer from HiddenOre also needs to go but it's a mess to keep it while also keeping cave ore generation a thing |
Yeah, PseudoServer has the Minestom approach [of only adding what you need], whereas extending CraftServer would be the PaperMC approach [of disabling what you don't want]. PseudoServer was added back in the 1.16.4 days (before even the move to Gradle) to avoid spinning up a whole server (and figuring out where the server files should go and when they should be cleaned up) just to test some item stuff. Now that we have :runServer, this is far less of an issue. |
mockbukkit btw |
btw, mockbukkit != craftbukkit |
If you intend to go through with this, you should probably remove junit and the test source set altogether too. We simply do not have well any enough managed or organised projects for it, and the stuff we need to test for, like item matching, requires a minimum level of server bootstrapping. It would probably be better to move any test stuff to |
It's annoying to maintain and not actually necessary