This repository has been archived by the owner on Feb 17, 2024. It is now read-only.
Fix RandomSpawn nether issues #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is some *odd* behaviour with the Nether where using the getMaxHeight() API would mean sometimes spawning the player above the roof-bedrock and killing them.
wingzero54
reviewed
Jul 16, 2023
wingzero54
approved these changes
Jul 16, 2023
That's fair. iirc, the typical thing is that, after a new release is made, you immediately commit an update to the version to make it a snapshot. So it'd be like this:
That way, the whole snapshot system is already out of the way when doing PR admin. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the obnoxious respawning behaviour in the Nether of constantly finding yourself in lava lakes or above the roof-bedrock. RedDevel and I did a 10-respawn test where I was pearled and killed 10 times to force a respawn. All 10 respawns were in perfectly valid locations.