Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Utility.isDroppedReinforcementBlock bad enum value #103

Closed
erocs opened this issue May 28, 2015 · 14 comments
Closed

Utility.isDroppedReinforcementBlock bad enum value #103

erocs opened this issue May 28, 2015 · 14 comments
Assignees
@rourke750
Labels
bug P1 - Critical

Comments

@erocs
Copy link

erocs commented May 28, 2015

2015-05-28 13:50:21 [WARN] java.lang.IllegalArgumentException: No enum constant org.bukkit.Material.§o§&§&§&§r§i§t§e§m§&§&§&§r§3§8§3§&§&§&§r§9§5§&§&§&
§r§1§&§&§&§r§&§&§&§r§&§&§&§r§0§&§&§&§r§&§&§&§r§&§&§&§r§&§&§&§r§&§&§&§r§r
2015-05-28 13:50:21 [WARN] at java.lang.Enum.valueOf(Enum.java:238)
2015-05-28 13:50:21 [WARN] at org.bukkit.Material.valueOf(Material.java:1)
2015-05-28 13:50:21 [WARN] at vg.civcraft.mc.citadel.Utility.isDroppedReinforcementBlock(Utility.java:461)
2015-05-28 13:50:21 [WARN] at vg.civcraft.mc.citadel.listener.BlockListener.onFortificationMode(BlockListener.java:85)
2015-05-28 13:50:21 [WARN] at sun.reflect.GeneratedMethodAccessor111.invoke(Unknown Source)
2015-05-28 13:50:21 [WARN] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
2015-05-28 13:50:21 [WARN] at java.lang.reflect.Method.invoke(Method.java:497)
2015-05-28 13:50:21 [WARN] at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:301)
2015-05-28 13:50:21 [WARN] at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62)
2015-05-28 13:50:21 [WARN] at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:502)
2015-05-28 13:50:21 [WARN] at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:487)
2015-05-28 13:50:21 [WARN] at org.bukkit.craftbukkit.v1_8_R2.event.CraftEventFactory.callBlockPlaceEvent(CraftEventFactory.java:126)
2015-05-28 13:50:21 [WARN] at net.minecraft.server.v1_8_R2.ItemStack.placeItem(ItemStack.java:157)
2015-05-28 13:50:21 [WARN] at net.minecraft.server.v1_8_R2.PlayerInteractManager.interact(PlayerInteractManager.java:503)
2015-05-28 13:50:21 [WARN] at net.minecraft.server.v1_8_R2.PlayerConnection.a(PlayerConnection.java:740)
2015-05-28 13:50:21 [WARN] at net.minecraft.server.v1_8_R2.PacketPlayInBlockPlace.a(PacketPlayInBlockPlace.java:52)
2015-05-28 13:50:21 [WARN] at net.minecraft.server.v1_8_R2.PacketPlayInBlockPlace.a(PacketPlayInBlockPlace.java:1)
2015-05-28 13:50:21 [WARN] at net.minecraft.server.v1_8_R2.PlayerConnectionUtils$1.run(SourceFile:13)
2015-05-28 13:50:21 [WARN] at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
2015-05-28 13:50:21 [WARN] at java.util.concurrent.FutureTask.run(FutureTask.java:266)
2015-05-28 13:50:21 [WARN] at net.minecraft.server.v1_8_R2.SystemUtils.a(SourceFile:60)
2015-05-28 13:50:21 [WARN] at net.minecraft.server.v1_8_R2.MinecraftServer.A(MinecraftServer.java:710)
2015-05-28 13:50:21 [WARN] at net.minecraft.server.v1_8_R2.DedicatedServer.A(DedicatedServer.java:368)
2015-05-28 13:50:21 [WARN] at net.minecraft.server.v1_8_R2.MinecraftServer.z(MinecraftServer.java:651)
2015-05-28 13:50:21 [WARN] at net.minecraft.server.v1_8_R2.MinecraftServer.run(MinecraftServer.java:554)
2015-05-28 13:50:21 [WARN] at java.lang.Thread.run(Thread.java:745)
@rourke750
Copy link

Uh what lol. Did we lose trapped_chest as an enum?

@erocs
Copy link
Author

erocs commented May 28, 2015

Nope. https://hub.spigotmc.org/javadocs/bukkit/org/bukkit/Material.html#TRAPPED_CHEST

@erocs
Copy link
Author

erocs commented May 28, 2015

We did lose LOCKED_CHEST, but that was an April Fool's build block anyway.

@rourke750
Copy link

Looks like I just need to remove this line: https://github.com/Civcraft/Citadel/blob/master/src/vg/civcraft/mc/citadel/Utility.java#L491 Looks like it won't break anything though as it does what it is supposed to.

@ProgrammerDan
Copy link

I'd strongly recommend just adding another catch(IllegalArgumentException iae) {} to deal with this specific, "valid" exception, and leave your catch-all as-is.

@rourke750
Copy link

Ah smart. Will do.

@rourke750 rourke750 self-assigned this May 28, 2015
@erocs
Copy link
Author

erocs commented May 28, 2015

I think the bigger problem is where did this bogus lore come from? I'd rather not have some arbitrarily set value being used to dictate reinforcement material.

@rourke750
Copy link

It was most likely someone placing a block that had lore on it.

@erocs
Copy link
Author

erocs commented May 28, 2015

Yes, so where did the lore come from? Looks unrecognizable to me.

On Thu, May 28, 2015 at 1:48 PM, rourke750 notifications@github.com wrote:

It was most likely someone placing a block that had lore on it.

—
Reply to this email directly or view it on GitHub
#103 (comment).

@rourke750
Copy link

Someone most likely placed a bastion without ctf. Bastions when created
have lore right?

On Thu, May 28, 2015 at 4:55 PM, erocs notifications@github.com wrote:

Yes, so where did the lore come from? Looks unrecognizable to me.

On Thu, May 28, 2015 at 1:48 PM, rourke750 notifications@github.com
wrote:

It was most likely someone placing a block that had lore on it.

—
Reply to this email directly or view it on GitHub
#103 (comment).

—
Reply to this email directly or view it on GitHub
#103 (comment).

@ttk2
Copy link

ttk2 commented May 28, 2015

so we don't parse out bad lore before doing anything? Sounds like an issue,
also this is what probably broke grepping the server log this morning, now
we have to use grep -a

On Thu, May 28, 2015 at 3:58 PM rourke750 notifications@github.com wrote:

Someone most likely placed a bastion without ctf. Bastions when created
have lore right?

On Thu, May 28, 2015 at 4:55 PM, erocs notifications@github.com wrote:

Yes, so where did the lore come from? Looks unrecognizable to me.

On Thu, May 28, 2015 at 1:48 PM, rourke750 notifications@github.com
wrote:

It was most likely someone placing a block that had lore on it.

—
Reply to this email directly or view it on GitHub
<#103 (comment)
.

—
Reply to this email directly or view it on GitHub
#103 (comment).

—
Reply to this email directly or view it on GitHub
#103 (comment).

@rourke750
Copy link

c1559e1

http://192.95.27.125:8080/view/Latest/job/Citadel-master/131/

@ttk2
Copy link

ttk2 commented May 29, 2015

on civtest.

On Thu, May 28, 2015 at 7:42 PM rourke750 notifications@github.com wrote:

c1559e1
c1559e1

http://192.95.27.125:8080/view/Latest/job/Citadel-master/131/

—
Reply to this email directly or view it on GitHub
#103 (comment).

@ttk2
Copy link

ttk2 commented May 29, 2015

statged for tmorrow

On Thu, May 28, 2015 at 7:42 PM justin kilpatrick <
kilpatrickjustin@gmail.com> wrote:

on civtest.

On Thu, May 28, 2015 at 7:42 PM rourke750 notifications@github.com
wrote:

c1559e1
c1559e1

http://192.95.27.125:8080/view/Latest/job/Citadel-master/131/

—
Reply to this email directly or view it on GitHub
#103 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rourke750 rourke750

Labels
bug P1 - Critical
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ProgrammerDan @ttk2 @erocs @WildWeazel @rourke750