Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug report: adjust frame testing for pa11y #642

Open
dmundra opened this issue Jun 24, 2022 · 0 comments
Open

Bug report: adjust frame testing for pa11y #642

dmundra opened this issue Jun 24, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@dmundra
Copy link
Contributor

dmundra commented Jun 24, 2022

Describe the bug
Similar to #589, we get this error from pa11y when testing without ignore 'frame-tested' (https://dequeuniversity.com/rules/axe/4.1/frame-tested)

Frames should be tested with axe-core
   (https://dequeuniversity.com/rules/axe/4.3/frame-tested?application=axeAPI)

   (#main-content > div:nth-child(2) > div > div > div > iframe)

   <iframe width="100%" height="1400"
   src="https://datastudio.google.com/embed/reporting/079817f9-e5dc-4442-91fe-c7beee6bb0f2/page/1M"
   frameborder="0" style="border:0" allowfullscreen="" title="Google Analytics
   Dashboard"></iframe>

Maybe we can adjust our settings and then remove the ignore rule.

@dmundra dmundra added the bug Something isn't working label Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

1 participant