qemu: aarch64: switch to -cpu max for PAC/BTI #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PAC/BTI instructions were added in v8.3a/v8.5a. (See https://reviews.llvm.org/D62609). Without enabling this cpu, the instructions are treated as NOPS. Switch to a CPU that will use these instructions, testing kernel configs (CONFIG_ARM64_PTR_AUTH, CONFIG_ARM64_BTI) which we will ship and Android+CrOS as soon as hardware is available. Suggested-by: Mark Brown <broonie@kernel.org>
|
thanks for the reviews! |
nickdesaulniers
added a commit
to ClangBuiltLinux/continuous-integration
that referenced
this pull request
Jun 22, 2020
Changing -cpu to max in ClangBuiltLinux/boot-utils#20 for PAC+BTI emulation seems to have slowed our boot tests down. Fixes: https://github.com/ClangBuiltLinux/linux/issues/1058 Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PAC/BTI instructions were added in v8.3a/v8.5a.
(See https://reviews.llvm.org/D62609).
Without enabling this cpu, the instructions are treated as NOPS. Switch
to a CPU that will use these instructions, testing kernel configs
(CONFIG_ARM64_PTR_AUTH, CONFIG_ARM64_BTI) which we will ship and
Android+CrOS as soon as hardware is available.
Suggested-by: Mark Brown broonie@kernel.org