Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-Wunused-variable in arch/arm/mach-omap1/board-h2.c #1325

Closed
nickdesaulniers opened this issue Mar 8, 2021 · 3 comments
Closed

-Wunused-variable in arch/arm/mach-omap1/board-h2.c #1325

nickdesaulniers opened this issue Mar 8, 2021 · 3 comments
Labels
-Wunused-variable [ARCH] arm32 This bug impacts ARCH=arm [BUG] linux A bug that should be fixed in the mainline kernel. [FIXED][LINUX] 5.13 This bug was fixed in Linux 5.13

Comments

@nickdesaulniers
Copy link
Member

via omap1_defconfig on linux-next:

arch/arm/mach-omap1/board-h2.c:347:34: warning: unused variable 'isp1301_gpiod_table' [-Wunused-variable]
static struct gpiod_lookup_table isp1301_gpiod_table = {
                                 ^
@nickdesaulniers nickdesaulniers added good first issue Good for newcomers [BUG] linux A bug that should be fixed in the mainline kernel. [ARCH] arm32 This bug impacts ARCH=arm -Wunused-variable labels Mar 8, 2021
@nickdesaulniers
Copy link
Member Author

Submitted: https://lore.kernel.org/lkml/20210401162032.10150-1-maciej.falkowski9@gmail.com/

@nickdesaulniers nickdesaulniers added the [PATCH] Submitted A patch has been submitted for review label Apr 1, 2021
fengguang pushed a commit to 0day-ci/linux that referenced this issue Apr 1, 2021
@m-falkowski @intel-lab-lkp
usb: isp1301-omap: Add missing gpiod_add_lookup_table function
6b3174b 
The gpiod table was added without any usage making it unused
as reported by Clang compilation from omap1_defconfig on linux-next:

arch/arm/mach-omap1/board-h2.c:347:34: warning: unused variable 'isp1301_gpiod_table' [-Wunused-variable]
static struct gpiod_lookup_table isp1301_gpiod_table = {
                                 ^
1 warning generated.

The patch adds the missing gpiod_add_lookup_table() function.

Signed-off-by: Maciej Falkowski <maciej.falkowski9@gmail.com>
Fixes: f3ef381 ("usb: isp1301-omap: Convert to use GPIO descriptors")
Link: ClangBuiltLinux#1325
@nickdesaulniers nickdesaulniers removed the good first issue Good for newcomers label May 18, 2021
@m-falkowski
Copy link

Patch accepted: https://lore.kernel.org/lkml/YKNh5ekJ1ffBZ+xd@atomide.com/

@nickdesaulniers nickdesaulniers added [PATCH] Accepted A submitted patch has been accepted upstream and removed [PATCH] Submitted A patch has been submitted for review labels May 19, 2021
fengguang pushed a commit to 0day-ci/linux that referenced this issue May 22, 2021
@m-falkowski @tmlind
ARM: OMAP1: isp1301-omap: Add missing gpiod_add_lookup_table function
7c30231 
The gpiod table was added without any usage making it unused
as reported by Clang compilation from omap1_defconfig on linux-next:

arch/arm/mach-omap1/board-h2.c:347:34: warning: unused variable
'isp1301_gpiod_table' [-Wunused-variable]
static struct gpiod_lookup_table isp1301_gpiod_table = {
                                 ^
1 warning generated.

The patch adds the missing gpiod_add_lookup_table() function.

Signed-off-by: Maciej Falkowski <maciej.falkowski9@gmail.com>
Fixes: f3ef381 ("usb: isp1301-omap: Convert to use GPIO descriptors")
Link: ClangBuiltLinux#1325
Signed-off-by: Tony Lindgren <tony@atomide.com>
@nickdesaulniers
Copy link
Member Author

fixed: 7c30231

@nickdesaulniers nickdesaulniers added [FIXED][LINUX] 5.13 This bug was fixed in Linux 5.13 and removed [PATCH] Accepted A submitted patch has been accepted upstream labels Jun 8, 2021
hamadmarri pushed a commit to hamadmarri/linux that referenced this issue Jun 9, 2021
@m-falkowski @gregkh
ARM: OMAP1: isp1301-omap: Add missing gpiod_add_lookup_table function
04639eb 
commit 7c30231 upstream.

The gpiod table was added without any usage making it unused
as reported by Clang compilation from omap1_defconfig on linux-next:

arch/arm/mach-omap1/board-h2.c:347:34: warning: unused variable
'isp1301_gpiod_table' [-Wunused-variable]
static struct gpiod_lookup_table isp1301_gpiod_table = {
                                 ^
1 warning generated.

The patch adds the missing gpiod_add_lookup_table() function.

Signed-off-by: Maciej Falkowski <maciej.falkowski9@gmail.com>
Fixes: f3ef381 ("usb: isp1301-omap: Convert to use GPIO descriptors")
Link: ClangBuiltLinux#1325
Signed-off-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
woodsts pushed a commit to woodsts/linux-stable that referenced this issue Jun 10, 2021
@m-falkowski @gregkh
ARM: OMAP1: isp1301-omap: Add missing gpiod_add_lookup_table function
3762e84 
commit 7c30231 upstream.

The gpiod table was added without any usage making it unused
as reported by Clang compilation from omap1_defconfig on linux-next:

arch/arm/mach-omap1/board-h2.c:347:34: warning: unused variable
'isp1301_gpiod_table' [-Wunused-variable]
static struct gpiod_lookup_table isp1301_gpiod_table = {
                                 ^
1 warning generated.

The patch adds the missing gpiod_add_lookup_table() function.

Signed-off-by: Maciej Falkowski <maciej.falkowski9@gmail.com>
Fixes: f3ef381 ("usb: isp1301-omap: Convert to use GPIO descriptors")
Link: ClangBuiltLinux/linux#1325
Signed-off-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
-Wunused-variable [ARCH] arm32 This bug impacts ARCH=arm [BUG] linux A bug that should be fixed in the mainline kernel. [FIXED][LINUX] 5.13 This bug was fixed in Linux 5.13
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nickdesaulniers @m-falkowski