Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-Wunused-but-set-variable in fs/btrfs/delayed-inode.c #1391

Closed
nathanchance opened this issue Jun 3, 2021 · 2 comments
Closed

-Wunused-but-set-variable in fs/btrfs/delayed-inode.c #1391

nathanchance opened this issue Jun 3, 2021 · 2 comments
Assignees
@nathanchance
Labels
-Wunused-but-set-variable [BUG] linux A bug that should be fixed in the mainline kernel. [FIXED][LINUX] 5.14 This bug was fixed in Linux 5.14

Comments

@nathanchance
Copy link
Member 

fs/btrfs/delayed-inode.c:684:6: warning: variable 'total_data_size' set but not used [-Wunused-but-set-variable]
        int total_data_size = 0, total_size = 0;
            ^
1 warning generated.

Patch submitted: https://lore.kernel.org/r/20210603174311.1008645-1-nathan@kernel.org/
@nathanchance nathanchance added [BUG] linux A bug that should be fixed in the mainline kernel. [PATCH] Submitted A patch has been submitted for review -Wunused-but-set-variable labels Jun 3, 2021
@nathanchance nathanchance self-assigned this Jun 3, 2021
fengguang pushed a commit to 0day-ci/linux that referenced this issue Jun 3, 2021
@nathanchance @intel-lab-lkp
btrfs: Remove total_data_size variable in btrfs_batch_insert_items()
c0b94e4 
clang warns:

fs/btrfs/delayed-inode.c:684:6: warning: variable 'total_data_size' set
but not used [-Wunused-but-set-variable]
        int total_data_size = 0, total_size = 0;
            ^
1 warning generated.

This variable's value has been unused since commit fc0d82e ("btrfs:
sink total_data parameter in setup_items_for_insert"). Eliminate it.

Fixes: fc0d82e ("btrfs: sink total_data parameter in setup_items_for_insert")
Link: ClangBuiltLinux#1391
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
kdave pushed a commit to kdave/btrfs-devel that referenced this issue Jun 4, 2021
@nathanchance @kdave
btrfs: remove total_data_size variable in btrfs_batch_insert_items()
3f3a096 
clang warns:

  fs/btrfs/delayed-inode.c:684:6: warning: variable 'total_data_size' set
  but not used [-Wunused-but-set-variable]
	  int total_data_size = 0, total_size = 0;
	      ^
  1 warning generated.

This variable's value has been unused since commit fc0d82e ("btrfs:
sink total_data parameter in setup_items_for_insert"). Eliminate it.

Link: ClangBuiltLinux#1391
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
@nickdesaulniers
Copy link
Member

accepted: kdave@3f3a096

@nickdesaulniers nickdesaulniers added [PATCH] Accepted A submitted patch has been accepted upstream and removed [PATCH] Submitted A patch has been submitted for review labels Jun 4, 2021
nathanchance added a commit to nathanchance/WSL2-Linux-Kernel that referenced this issue Jun 5, 2021
@nathanchance
btrfs: Remove total_data_size variable in btrfs_batch_insert_items()
de44982 
clang warns:

fs/btrfs/delayed-inode.c:684:6: warning: variable 'total_data_size' set
but not used [-Wunused-but-set-variable]
        int total_data_size = 0, total_size = 0;
            ^
1 warning generated.

This variable's value has been unused since commit fc0d82e ("btrfs:
sink total_data parameter in setup_items_for_insert"). Eliminate it.

Fixes: fc0d82e ("btrfs: sink total_data parameter in setup_items_for_insert")
Link: ClangBuiltLinux/linux#1391
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Link: https://lore.kernel.org/r/20210603174311.1008645-1-nathan@kernel.org
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
nathanchance added a commit to nathanchance/WSL2-Linux-Kernel that referenced this issue Jun 5, 2021
@nathanchance
btrfs: Remove total_data_size variable in btrfs_batch_insert_items()
7230e8d 
clang warns:

fs/btrfs/delayed-inode.c:684:6: warning: variable 'total_data_size' set
but not used [-Wunused-but-set-variable]
        int total_data_size = 0, total_size = 0;
            ^
1 warning generated.

This variable's value has been unused since commit fc0d82e ("btrfs:
sink total_data parameter in setup_items_for_insert"). Eliminate it.

Fixes: fc0d82e ("btrfs: sink total_data parameter in setup_items_for_insert")
Link: ClangBuiltLinux/linux#1391
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Link: https://lore.kernel.org/r/20210603174311.1008645-1-nathan@kernel.org
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
kdave pushed a commit to kdave/btrfs-devel that referenced this issue Jun 7, 2021
@nathanchance @kdave
btrfs: remove total_data_size variable in btrfs_batch_insert_items()
a6aa00f 
clang warns:

  fs/btrfs/delayed-inode.c:684:6: warning: variable 'total_data_size' set
  but not used [-Wunused-but-set-variable]
	  int total_data_size = 0, total_size = 0;
	      ^
  1 warning generated.

This variable's value has been unused since commit fc0d82e ("btrfs:
sink total_data parameter in setup_items_for_insert"). Eliminate it.

Link: ClangBuiltLinux#1391
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
kdave pushed a commit to kdave/btrfs-devel that referenced this issue Jun 7, 2021
@nathanchance @kdave
btrfs: remove total_data_size variable in btrfs_batch_insert_items()
4c0f7a6 
clang warns:

  fs/btrfs/delayed-inode.c:684:6: warning: variable 'total_data_size' set
  but not used [-Wunused-but-set-variable]
	  int total_data_size = 0, total_size = 0;
	      ^
  1 warning generated.

This variable's value has been unused since commit fc0d82e ("btrfs:
sink total_data parameter in setup_items_for_insert"). Eliminate it.

Link: ClangBuiltLinux#1391
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
kdave pushed a commit to kdave/btrfs-devel that referenced this issue Jun 7, 2021
@nathanchance @kdave
btrfs: remove total_data_size variable in btrfs_batch_insert_items()
1f02420 
clang warns:

  fs/btrfs/delayed-inode.c:684:6: warning: variable 'total_data_size' set
  but not used [-Wunused-but-set-variable]
	  int total_data_size = 0, total_size = 0;
	      ^
  1 warning generated.

This variable's value has been unused since commit fc0d82e ("btrfs:
sink total_data parameter in setup_items_for_insert"). Eliminate it.

Link: ClangBuiltLinux#1391
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
nathanchance added a commit to nathanchance/WSL2-Linux-Kernel that referenced this issue Jun 8, 2021
@nathanchance
btrfs: Remove total_data_size variable in btrfs_batch_insert_items()
4b6948c 
clang warns:

fs/btrfs/delayed-inode.c:684:6: warning: variable 'total_data_size' set
but not used [-Wunused-but-set-variable]
        int total_data_size = 0, total_size = 0;
            ^
1 warning generated.

This variable's value has been unused since commit fc0d82e ("btrfs:
sink total_data parameter in setup_items_for_insert"). Eliminate it.

Fixes: fc0d82e ("btrfs: sink total_data parameter in setup_items_for_insert")
Link: ClangBuiltLinux/linux#1391
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Link: https://lore.kernel.org/r/20210603174311.1008645-1-nathan@kernel.org
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
kdave pushed a commit to kdave/btrfs-devel that referenced this issue Jun 9, 2021
@nathanchance @kdave
btrfs: remove total_data_size variable in btrfs_batch_insert_items()
02598e3 
clang warns:

  fs/btrfs/delayed-inode.c:684:6: warning: variable 'total_data_size' set
  but not used [-Wunused-but-set-variable]
	  int total_data_size = 0, total_size = 0;
	      ^
  1 warning generated.

This variable's value has been unused since commit fc0d82e ("btrfs:
sink total_data parameter in setup_items_for_insert"). Eliminate it.

Link: ClangBuiltLinux#1391
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
nathanchance added a commit to nathanchance/WSL2-Linux-Kernel that referenced this issue Jun 9, 2021
@nathanchance
btrfs: Remove total_data_size variable in btrfs_batch_insert_items()
7864855 
clang warns:

fs/btrfs/delayed-inode.c:684:6: warning: variable 'total_data_size' set
but not used [-Wunused-but-set-variable]
        int total_data_size = 0, total_size = 0;
            ^
1 warning generated.

This variable's value has been unused since commit fc0d82e ("btrfs:
sink total_data parameter in setup_items_for_insert"). Eliminate it.

Fixes: fc0d82e ("btrfs: sink total_data parameter in setup_items_for_insert")
Link: ClangBuiltLinux/linux#1391
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Link: https://lore.kernel.org/r/20210603174311.1008645-1-nathan@kernel.org
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
kdave pushed a commit to kdave/btrfs-devel that referenced this issue Jun 11, 2021
@nathanchance @kdave
btrfs: remove total_data_size variable in btrfs_batch_insert_items()
abffed6 
clang warns:

  fs/btrfs/delayed-inode.c:684:6: warning: variable 'total_data_size' set
  but not used [-Wunused-but-set-variable]
	  int total_data_size = 0, total_size = 0;
	      ^
  1 warning generated.

This variable's value has been unused since commit fc0d82e ("btrfs:
sink total_data parameter in setup_items_for_insert"). Eliminate it.

Link: ClangBuiltLinux#1391
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
nathanchance added a commit to nathanchance/WSL2-Linux-Kernel that referenced this issue Jun 11, 2021
@nathanchance
btrfs: Remove total_data_size variable in btrfs_batch_insert_items()
ea1db23 
clang warns:

fs/btrfs/delayed-inode.c:684:6: warning: variable 'total_data_size' set
but not used [-Wunused-but-set-variable]
        int total_data_size = 0, total_size = 0;
            ^
1 warning generated.

This variable's value has been unused since commit fc0d82e ("btrfs:
sink total_data parameter in setup_items_for_insert"). Eliminate it.

Fixes: fc0d82e ("btrfs: sink total_data parameter in setup_items_for_insert")
Link: ClangBuiltLinux/linux#1391
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Link: https://lore.kernel.org/r/20210603174311.1008645-1-nathan@kernel.org
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
nathanchance added a commit to nathanchance/WSL2-Linux-Kernel that referenced this issue Jun 11, 2021
@nathanchance
btrfs: Remove total_data_size variable in btrfs_batch_insert_items()
12799a7 
clang warns:

fs/btrfs/delayed-inode.c:684:6: warning: variable 'total_data_size' set
but not used [-Wunused-but-set-variable]
        int total_data_size = 0, total_size = 0;
            ^
1 warning generated.

This variable's value has been unused since commit fc0d82e ("btrfs:
sink total_data parameter in setup_items_for_insert"). Eliminate it.

Fixes: fc0d82e ("btrfs: sink total_data parameter in setup_items_for_insert")
Link: ClangBuiltLinux/linux#1391
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Link: https://lore.kernel.org/r/20210603174311.1008645-1-nathan@kernel.org
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
kdave pushed a commit to kdave/btrfs-devel that referenced this issue Jun 14, 2021
@nathanchance @kdave
btrfs: remove total_data_size variable in btrfs_batch_insert_items()
c5ca87b 
clang warns:

  fs/btrfs/delayed-inode.c:684:6: warning: variable 'total_data_size' set
  but not used [-Wunused-but-set-variable]
	  int total_data_size = 0, total_size = 0;
	      ^
  1 warning generated.

This variable's value has been unused since commit fc0d82e ("btrfs:
sink total_data parameter in setup_items_for_insert"). Eliminate it.

Link: ClangBuiltLinux#1391
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
kdave pushed a commit to kdave/btrfs-devel that referenced this issue Jun 16, 2021
@nathanchance @kdave
btrfs: remove total_data_size variable in btrfs_batch_insert_items()
05a9774 
clang warns:

  fs/btrfs/delayed-inode.c:684:6: warning: variable 'total_data_size' set
  but not used [-Wunused-but-set-variable]
	  int total_data_size = 0, total_size = 0;
	      ^
  1 warning generated.

This variable's value has been unused since commit fc0d82e ("btrfs:
sink total_data parameter in setup_items_for_insert"). Eliminate it.

Link: ClangBuiltLinux#1391
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
kdave pushed a commit to kdave/btrfs-devel that referenced this issue Jun 17, 2021
@nathanchance @kdave
btrfs: remove total_data_size variable in btrfs_batch_insert_items()
7f962ca 
clang warns:

  fs/btrfs/delayed-inode.c:684:6: warning: variable 'total_data_size' set
  but not used [-Wunused-but-set-variable]
	  int total_data_size = 0, total_size = 0;
	      ^
  1 warning generated.

This variable's value has been unused since commit fc0d82e ("btrfs:
sink total_data parameter in setup_items_for_insert"). Eliminate it.

Link: ClangBuiltLinux#1391
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
kdave pushed a commit to kdave/btrfs-devel that referenced this issue Jun 17, 2021
@nathanchance @kdave
btrfs: remove total_data_size variable in btrfs_batch_insert_items()
88f91a3 
clang warns:

  fs/btrfs/delayed-inode.c:684:6: warning: variable 'total_data_size' set
  but not used [-Wunused-but-set-variable]
	  int total_data_size = 0, total_size = 0;
	      ^
  1 warning generated.

This variable's value has been unused since commit fc0d82e ("btrfs:
sink total_data parameter in setup_items_for_insert"). Eliminate it.

Link: ClangBuiltLinux#1391
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
kdave pushed a commit to kdave/btrfs-devel that referenced this issue Jun 21, 2021
@nathanchance @kdave
btrfs: remove total_data_size variable in btrfs_batch_insert_items()
bfaa324 
clang warns:

  fs/btrfs/delayed-inode.c:684:6: warning: variable 'total_data_size' set
  but not used [-Wunused-but-set-variable]
	  int total_data_size = 0, total_size = 0;
	      ^
  1 warning generated.

This variable's value has been unused since commit fc0d82e ("btrfs:
sink total_data parameter in setup_items_for_insert"). Eliminate it.

Link: ClangBuiltLinux#1391
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
@nathanchance
Copy link
Member Author

Fixed: https://git.kernel.org/torvalds/c/bfaa324e9a80

@nathanchance nathanchance added [FIXED][LINUX] 5.14 This bug was fixed in Linux 5.14 and removed [PATCH] Accepted A submitted patch has been accepted upstream labels Jun 28, 2021
intersectRaven pushed a commit to intersectRaven/linux that referenced this issue Jun 29, 2021
@nathanchance @intersectRaven
btrfs: remove total_data_size variable in btrfs_batch_insert_items()
faba4f9 
clang warns:

  fs/btrfs/delayed-inode.c:684:6: warning: variable 'total_data_size' set
  but not used [-Wunused-but-set-variable]
	  int total_data_size = 0, total_size = 0;
	      ^
  1 warning generated.

This variable's value has been unused since commit fc0d82e ("btrfs:
sink total_data parameter in setup_items_for_insert"). Eliminate it.

Link: ClangBuiltLinux#1391
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nathanchance nathanchance

Labels
-Wunused-but-set-variable [BUG] linux A bug that should be fixed in the mainline kernel. [FIXED][LINUX] 5.14 This bug was fixed in Linux 5.14
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nickdesaulniers @nathanchance