Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linking module flags 'warn-stack-size': IDs have conflicting values #1395

Closed
nickdesaulniers opened this issue Jun 11, 2021 · 2 comments
Closed

linking module flags 'warn-stack-size': IDs have conflicting values #1395

nickdesaulniers opened this issue Jun 11, 2021 · 2 comments
Assignees
@nickdesaulniers
Labels
[ARCH] x86 This bug impacts ARCH=i386 [BUG] llvm (main) A bug in an unreleased version of LLVM (this label is appropriate for regressions) [FEATURE] LTO Related to building the kernel with LLVM Link Time Optimization [FIXED][LLVM] main This bug was only present and fixed in an unreleased version of LLVM

Comments

@nickdesaulniers
Copy link
Member

nickdesaulniers commented Jun 11, 2021 •
edited
Loading

while testing #1215 I hit fallout from #1377 . This was from:
$ ARCH=i386 make -j71 LLVM=1 LLVM_IAS=1 allmodconfig
on linux-next with:

  • FTRACE disabled
  • GCOV_KERNEL disabled
  • CONFIG_COMPILE_TEST disabled
  • full lto enabled
ld.lld: error: linking module flags 'warn-stack-size': IDs have conflicting values in 'drivers/gpu/drm/amd/amdgpu/amdgpu.o(display_mode_vba_30.o at 159566)' and 'ld-temp.o'

so as part of #1377 (https://reviews.llvm.org/D103928) we cannot support differing frame sizes to warn on when building full LTO. This hasn't been an issue in the past because LLVM was dropping the flag outright due to #1374 (https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0024430e920f2900654ad83cd081cf52e02a3ef5).

drivers/gpu/drm/amd/display/dc/dml/Makefile relaxes the set config to -Wframe-larger-than=2048 for a couple of files.
@nickdesaulniers nickdesaulniers added [ARCH] x86 This bug impacts ARCH=i386 [FEATURE] LTO Related to building the kernel with LLVM Link Time Optimization labels Jun 11, 2021
@nickdesaulniers nickdesaulniers mentioned this issue Jun 11, 2021
Open
@nickdesaulniers
Copy link
Member Author

We could fix the build failure on the LLVM side by taking the max of two different flags; ultimately though I think making these be function level attributes rather than module level attributes might be the best.

@nickdesaulniers
Copy link
Member Author

https://reviews.llvm.org/D104342

@nickdesaulniers nickdesaulniers self-assigned this Jun 16, 2021
@nickdesaulniers nickdesaulniers added [BUG] llvm (main) A bug in an unreleased version of LLVM (this label is appropriate for regressions) [PATCH] Submitted A patch has been submitted for review labels Jun 16, 2021
RealJohnGalt added a commit to RealJohnGalt/GaltsGulch-sm8150 that referenced this issue Jun 16, 2021
@RealJohnGalt
[HACK] treewide remove warn-stack-size usage.
123f893 
Workaround ClangBuiltLinux/linux#1395
temporarily.
@nickdesaulniers nickdesaulniers added [PATCH] Accepted A submitted patch has been accepted upstream and removed [PATCH] Submitted A patch has been submitted for review labels Jun 18, 2021
nickdesaulniers added a commit to llvm/llvm-project that referenced this issue Jun 21, 2021
@nickdesaulniers
[IR] convert warn-stack-size from module flag to fn attr
8ace121 
Otherwise, this causes issues when building with LTO for object files
that use different values.

Link: ClangBuiltLinux/linux#1395

Reviewed By: dblaikie, MaskRay

Differential Revision: https://reviews.llvm.org/D104342
@nickdesaulniers nickdesaulniers added [FIXED][LLVM] main This bug was only present and fixed in an unreleased version of LLVM and removed [PATCH] Accepted A submitted patch has been accepted upstream labels Jun 21, 2021
arichardson pushed a commit to arichardson/llvm-project that referenced this issue Sep 13, 2021
@nickdesaulniers @arichardson
[IR] convert warn-stack-size from module flag to fn attr
409264e 
Otherwise, this causes issues when building with LTO for object files
that use different values.

Link: ClangBuiltLinux/linux#1395

Reviewed By: dblaikie, MaskRay

Differential Revision: https://reviews.llvm.org/D104342
vgvassilev pushed a commit to vgvassilev/clang that referenced this issue Dec 28, 2022
@nickdesaulniers @vgvassilev
[IR] convert warn-stack-size from module flag to fn attr
3ed65ac 
Otherwise, this causes issues when building with LTO for object files
that use different values.

Link: ClangBuiltLinux/linux#1395

Reviewed By: dblaikie, MaskRay

Differential Revision: https://reviews.llvm.org/D104342

llvm-monorepo: 8ace12130526f450c822ca232d1f865b247d7434
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nickdesaulniers nickdesaulniers

Labels
[ARCH] x86 This bug impacts ARCH=i386 [BUG] llvm (main) A bug in an unreleased version of LLVM (this label is appropriate for regressions) [FEATURE] LTO Related to building the kernel with LLVM Link Time Optimization [FIXED][LLVM] main This bug was only present and fixed in an unreleased version of LLVM
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nickdesaulniers