Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-Wpointer-bool-conversion in drivers/scsi/elx/efct/efct_hw.c #1398

Closed
nathanchance opened this issue Jun 17, 2021 · 1 comment
Closed

-Wpointer-bool-conversion in drivers/scsi/elx/efct/efct_hw.c #1398

nathanchance opened this issue Jun 17, 2021 · 1 comment
Assignees
@nathanchance
Labels
-Wpointer-bool-conversion [BUG] linux-next This is an issue only seen in linux-next [FIXED][LINUX] development cycle This bug was only present and fixed in a -next or -rc cycle

Comments

@nathanchance
Copy link
Member 

drivers/scsi/elx/efct/efct_hw.c:1523:17: warning: address of array 'ctx->buf' will always evaluate to 'true' [-Wpointer-bool-conversion]
                              (!ctx->buf ? U32_MAX : *((u32 *)ctx->buf)));
                               ~~~~~~^~~
drivers/scsi/elx/efct/../libefc/../libefc_sli/../include/efc_common.h:35:38: note: expanded from macro 'efc_log_debug'
                dev_dbg(&((efc)->pci)->dev, fmt, ##args)
                                                   ^~~~
include/linux/dev_printk.h:123:39: note: expanded from macro 'dev_dbg'
        dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
                                             ^~~~~~~~~~~
include/linux/dynamic_debug.h:162:19: note: expanded from macro 'dynamic_dev_dbg'
                           dev, fmt, ##__VA_ARGS__)
                                       ^~~~~~~~~~~
include/linux/dynamic_debug.h:147:56: note: expanded from macro '_dynamic_func_call'
        __dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__)
                                                              ^~~~~~~~~~~
include/linux/dynamic_debug.h:129:15: note: expanded from macro '__dynamic_func_call'
                func(&id, ##__VA_ARGS__);               \
                            ^~~~~~~~~~~
1 warning generated.

Patch submitted: https://lore.kernel.org/r/20210617063123.21239-1-nathan@kernel.org/
@nathanchance nathanchance added -Wpointer-bool-conversion [PATCH] Submitted A patch has been submitted for review [BUG] linux-next This is an issue only seen in linux-next labels Jun 17, 2021
@nathanchance nathanchance self-assigned this Jun 17, 2021
fengguang pushed a commit to 0day-ci/linux that referenced this issue Jun 17, 2021
@nathanchance @intel-lab-lkp
scsi: elx: efct: Eliminate unnecessary boolean check in efct_hw_comma…
e411bdf 
…nd_cancel()

clang warns:

drivers/scsi/elx/efct/efct_hw.c:1523:17: warning: address of array
'ctx->buf' will always evaluate to 'true' [-Wpointer-bool-conversion]
                              (!ctx->buf ? U32_MAX : *((u32 *)ctx->buf)));
                               ~~~~~~^~~

buf is an array in the middle of a struct so deferencing it is not a
problem as long as ctx is not NULL. Eliminate the check, which fixes the
warning.

Fixes: 580c025 ("scsi: elx: efct: RQ buffer, memory pool allocation and deallocation APIs")
Link: ClangBuiltLinux#1398
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
fengguang pushed a commit to 0day-ci/linux that referenced this issue Jun 19, 2021
@nathanchance @martinkpetersen
scsi: elx: efct: Eliminate unnecessary boolean check in efct_hw_comma…
0d7be7a 
…nd_cancel()

clang warns:

drivers/scsi/elx/efct/efct_hw.c:1523:17: warning: address of array
'ctx->buf' will always evaluate to 'true' [-Wpointer-bool-conversion]
                              (!ctx->buf ? U32_MAX : *((u32 *)ctx->buf)));
                               ~~~~~~^~~

buf is an array in the middle of a struct so deferencing it is not a
problem as long as ctx is not NULL. Eliminate the check, which fixes the
warning.

Link: ClangBuiltLinux#1398
Link: https://lore.kernel.org/r/20210617063123.21239-1-nathan@kernel.org
Fixes: 580c025 ("scsi: elx: efct: RQ buffer, memory pool allocation and deallocation APIs")
Reviewed-by: James Smart <jsmart2021@gmail.com>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
@nathanchance
Copy link
Member Author

Fixed: https://git.kernel.org/next/linux-next/c/0d7be7a8a009

@nathanchance nathanchance added [FIXED][LINUX] development cycle This bug was only present and fixed in a -next or -rc cycle and removed [PATCH] Submitted A patch has been submitted for review labels Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nathanchance nathanchance

Labels
-Wpointer-bool-conversion [BUG] linux-next This is an issue only seen in linux-next [FIXED][LINUX] development cycle This bug was only present and fixed in a -next or -rc cycle
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nathanchance