-Wpointer-bool-conversion in drivers/net/ethernet/mellanox/mlx5/core/eq.c #1400
Assignees
Labels
-Wpointer-bool-conversion
[BUG] linux-next
This is an issue only seen in linux-next
[FIXED][LINUX] development cycle
This bug was only present and fixed in a -next or -rc cycle
Comments
nathanchance
added
-Wpointer-bool-conversion
[PATCH] Submitted
fengguang
pushed a commit
to 0day-ci/linux
that referenced
this issue
Jun 18, 2021
When CONFIG_CPUMASK_OFFSTACK is unset, cpumask_var_t is not a pointer
but a single element array, meaning its address in a structure cannot be
NULL as long as it is not the first element, which it is not. This
results in a clang warning:
drivers/net/ethernet/mellanox/mlx5/core/eq.c:715:14: warning: address of
array 'param->affinity' will always evaluate to 'true'
[-Wpointer-bool-conversion]
if (!param->affinity)
~~~~~~~~^~~~~~~~
1 warning generated.
The helper cpumask_available was added in commit f7e30f0 ("cpumask:
Add helper cpumask_available()") to handle situations like this so use
it to keep the meaning of the code the same while resolving the warning.
Fixes: e4e3f24 ("net/mlx5: Provide cpumask at EQ creation phase")
Link: ClangBuiltLinux#1400
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
|
sounds like it was accepted, perhaps not yet pushed: https://git.kernel.org/pub/scm/linux/kernel/git/saeed/linux.git/log/?h=net-next-mlx5 |
nickdesaulniers
added
[PATCH] Accepted
fengguang
pushed a commit
to 0day-ci/linux
that referenced
this issue
Jun 24, 2021
When CONFIG_CPUMASK_OFFSTACK is unset, cpumask_var_t is not a pointer
but a single element array, meaning its address in a structure cannot be
NULL as long as it is not the first element, which it is not. This
results in a clang warning:
drivers/net/ethernet/mellanox/mlx5/core/eq.c:715:14: warning: address of
array 'param->affinity' will always evaluate to 'true'
[-Wpointer-bool-conversion]
if (!param->affinity)
~~~~~~~~^~~~~~~~
1 warning generated.
The helper cpumask_available was added in commit f7e30f0 ("cpumask:
Add helper cpumask_available()") to handle situations like this so use
it to keep the meaning of the code the same while resolving the warning.
Fixes: e4e3f24 ("net/mlx5: Provide cpumask at EQ creation phase")
Link: ClangBuiltLinux#1400
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
nathanchance
added
[FIXED][LINUX] development cycle
oraclelinuxkernel
pushed a commit
to oracle/linux-uek
that referenced
this issue
Apr 28, 2023
When CONFIG_CPUMASK_OFFSTACK is unset, cpumask_var_t is not a pointer
but a single element array, meaning its address in a structure cannot be
NULL as long as it is not the first element, which it is not. This
results in a clang warning:
drivers/net/ethernet/mellanox/mlx5/core/eq.c:715:14: warning: address of
array 'param->affinity' will always evaluate to 'true'
[-Wpointer-bool-conversion]
if (!param->affinity)
~~~~~~~~^~~~~~~~
1 warning generated.
The helper cpumask_available was added in commit f7e30f0 ("cpumask:
Add helper cpumask_available()") to handle situations like this so use
it to keep the meaning of the code the same while resolving the warning.
Fixes: e4e3f24 ("net/mlx5: Provide cpumask at EQ creation phase")
Link: ClangBuiltLinux/linux#1400
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
Orabug: 34382720
(cherry picked from commit d4472a4)
cherry-pick-repo=kernel/git/torvalds/linux.git
unmodified-from-upstream: d4472a4
Signed-off-by: Mikhael Goikhman <migo@nvidia.com>
Signed-off-by: Qing Huang <qing.huang@oracle.com>
Reviewed-by: Devesh Sharma <devesh.s.sharma@oracle.com>
Signed-off-by: Brian Maly <brian.maly@oracle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Patch submitted: https://lore.kernel.org/r/20210618000358.2402567-1-nathan@kernel.org/
The text was updated successfully, but these errors were encountered: