Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-Wunneeded-internal-declaration in drivers/platform/x86/mlx-platform.c #141

Closed
tpimh opened this issue Sep 20, 2018 · 4 comments
Closed

-Wunneeded-internal-declaration in drivers/platform/x86/mlx-platform.c #141

tpimh opened this issue Sep 20, 2018 · 4 comments
Assignees
@nathanchance
Labels
-Wunneeded-internal-declaration [ARCH] x86_64 This bug impacts ARCH=x86_64 [BUG] linux A bug that should be fixed in the mainline kernel. [FIXED][LINUX] 4.20 This bug was fixed in Linux 4.20

Comments

@tpimh
Copy link

tpimh commented Sep 20, 2018 

drivers/platform/x86/mlx-platform.c:555:32: warning: variable 'mlxplat_mlxcpld_msn201x_items'
      is not needed and will not be emitted [-Wunneeded-internal-declaration]
static struct mlxreg_core_item mlxplat_mlxcpld_msn201x_items[] = {
                               ^
1 warning generated.
@tpimh tpimh added [BUG] linux A bug that should be fixed in the mainline kernel. [ARCH] x86_64 This bug impacts ARCH=x86_64 low priority This bug is not critical and not a priority labels Sep 20, 2018
@nathanchance nathanchance self-assigned this Sep 26, 2018
@nathanchance
Copy link
Member

Patch sent: https://lore.kernel.org/lkml/20180926052115.21223-1-natechancellor@gmail.com/

@nathanchance nathanchance added the [PATCH] Submitted A patch has been submitted for review label Sep 26, 2018
andy-shev pushed a commit to dvhart/linux-pdx86 that referenced this issue Oct 8, 2018
@nathanchance @andy-shev
platform/x86: mlx-platform: Properly use mlxplat_mlxcpld_msn201x_items
8289c4b 
Clang warns that mlxplat_mlxcpld_msn201x_items is not going to be
emitted in the final assembly because it's only used in ARRAY_SIZE right
now, which is a compile time evaluation since the array's size is known.

drivers/platform/x86/mlx-platform.c:555:32: warning: variable
'mlxplat_mlxcpld_msn201x_items' is not needed and will not be emitted
[-Wunneeded-internal-declaration]
static struct mlxreg_core_item mlxplat_mlxcpld_msn201x_items[] = {
                               ^
1 warning generated.

It appears this was a copy and paste mistake from when this item was
first added. Use the definition in mlxplat_mlxcpld_msn201x_data so that
Clang no longer warns.

Link: ClangBuiltLinux#141
Fixes: a49a414 ("platform/x86: mlx-platform: Add support for new msn201x system type")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Acked-by: Vadim Pasternak <vadimp@mellanox.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
@nathanchance
Copy link
Member

Patch accepted: http://git.infradead.org/linux-platform-drivers-x86.git/commit/8289c4b6f2e53750de78bd38cecb6bce4d7a988c

@nathanchance nathanchance added [PATCH] Accepted A submitted patch has been accepted upstream and removed [PATCH] Submitted A patch has been submitted for review labels Oct 8, 2018
@nathanchance
Copy link
Member

Merged into mainline: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8289c4b6f2e53750de78bd38cecb6bce4d7a988c

@nathanchance nathanchance added [FIXED][LINUX] 4.20 This bug was fixed in Linux 4.20 and removed [PATCH] Accepted A submitted patch has been accepted upstream labels Nov 2, 2018
@tpimh tpimh removed the low priority This bug is not critical and not a priority label Nov 2, 2018
@nickdesaulniers
Copy link
Member

possibly also fixed on the llvm side by #232

nathanchance pushed a commit that referenced this issue Jun 8, 2019
@geertu @paulburton
MIPS: TXx9: Fix boot crash in free_initmem()
c5eac1f 
On rbtx4927:

    BUG: Bad page state in process swapper  pfn:00001
    page:804b7820 refcount:0 mapcount:-128 mapping:00000000 index:0x1
    flags: 0x0()
    raw: 00000000 00000100 00000200 00000000 00000001 00000000 ffffff7f 00000000
    page dumped because: nonzero mapcount
    Modules linked in:
    CPU: 0 PID: 1 Comm: swapper Not tainted 5.2.0-rc1-rbtx4927-00468-g3c05ea3d4077b756 #141
    Stack : 00000000 10008400 8040dc4c 87c1b974 8044af63 8040dc4c 00000001 804a3490
            00000001 81000000 0030f231 80148558 00000003 10008400 87c1dd80 3d0f9a2c
            00000000 00000000 804b0000 00000000 00000007 00000000 00000081 00000000
            62722d31 00000080 804b0000 39347874 00000000 804b7820 8040ce18 81000010
            00000001 00000007 00000001 81000000 00000018 8021de24 00000000 804a0000
            ...
    Call Trace:
    [<8010adec>] show_stack+0x74/0x104
    [<801a5e44>] bad_page+0x130/0x138
    [<801a654c>] free_pcppages_bulk+0x17c/0x3b0
    [<801a789c>] free_unref_page+0x40/0x68
    [<801120f4>] free_init_pages+0xec/0x104
    [<803bdde8>] free_initmem+0x10/0x58
    [<803bdb8c>] kernel_init+0x20/0x100
    [<801057c8>] ret_from_kernel_thread+0x14/0x1c

As of commit b93ddc4 ("mips: Reserve memory for the kernel
image resources"), bootmem_init() no longer reserves the memory below
the kernel, while prom_free_prom_memory() still frees it.

Fix this by reverting commit b6263ff ("MIPS: TXx9: Implement
prom_free_prom_memory").

Suggested-by: Serge Semin <fancer.lancer@gmail.com>
Fixes: b93ddc4 ("mips: Reserve memory for the kernel image resources")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Reviewed-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Signed-off-by: Paul Burton <paul.burton@mips.com>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: James Hogan <jhogan@kernel.org>
Cc: Mike Rapoport <rppt@linux.ibm.com>
Cc: Maciej W . Rozycki <macro@linux-mips.org>
Cc: linux-mips@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
woodsts pushed a commit to woodsts/linux-stable that referenced this issue Nov 24, 2019
@nathanchance @gregkh
platform/x86: mlx-platform: Properly use mlxplat_mlxcpld_msn201x_items
2103ebd 
[ Upstream commit 8289c4b ]

Clang warns that mlxplat_mlxcpld_msn201x_items is not going to be
emitted in the final assembly because it's only used in ARRAY_SIZE right
now, which is a compile time evaluation since the array's size is known.

drivers/platform/x86/mlx-platform.c:555:32: warning: variable
'mlxplat_mlxcpld_msn201x_items' is not needed and will not be emitted
[-Wunneeded-internal-declaration]
static struct mlxreg_core_item mlxplat_mlxcpld_msn201x_items[] = {
                               ^
1 warning generated.

It appears this was a copy and paste mistake from when this item was
first added. Use the definition in mlxplat_mlxcpld_msn201x_data so that
Clang no longer warns.

Link: ClangBuiltLinux/linux#141
Fixes: a49a414 ("platform/x86: mlx-platform: Add support for new msn201x system type")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Acked-by: Vadim Pasternak <vadimp@mellanox.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
isjerryxiao pushed a commit to isjerryxiao/Amlogic_s905-kernel that referenced this issue Nov 25, 2019
@nathanchance @isjerryxiao
platform/x86: mlx-platform: Properly use mlxplat_mlxcpld_msn201x_items
749e63b 
[ Upstream commit 8289c4b ]

Clang warns that mlxplat_mlxcpld_msn201x_items is not going to be
emitted in the final assembly because it's only used in ARRAY_SIZE right
now, which is a compile time evaluation since the array's size is known.

drivers/platform/x86/mlx-platform.c:555:32: warning: variable
'mlxplat_mlxcpld_msn201x_items' is not needed and will not be emitted
[-Wunneeded-internal-declaration]
static struct mlxreg_core_item mlxplat_mlxcpld_msn201x_items[] = {
                               ^
1 warning generated.

It appears this was a copy and paste mistake from when this item was
first added. Use the definition in mlxplat_mlxcpld_msn201x_data so that
Clang no longer warns.

Link: ClangBuiltLinux/linux#141
Fixes: a49a414 ("platform/x86: mlx-platform: Add support for new msn201x system type")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Acked-by: Vadim Pasternak <vadimp@mellanox.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
mrchapp pushed a commit to mrchapp/linux that referenced this issue Nov 25, 2019
@nathanchance @gregkh
platform/x86: mlx-platform: Properly use mlxplat_mlxcpld_msn201x_items
97ce3cd 
[ Upstream commit 8289c4b ]

Clang warns that mlxplat_mlxcpld_msn201x_items is not going to be
emitted in the final assembly because it's only used in ARRAY_SIZE right
now, which is a compile time evaluation since the array's size is known.

drivers/platform/x86/mlx-platform.c:555:32: warning: variable
'mlxplat_mlxcpld_msn201x_items' is not needed and will not be emitted
[-Wunneeded-internal-declaration]
static struct mlxreg_core_item mlxplat_mlxcpld_msn201x_items[] = {
                               ^
1 warning generated.

It appears this was a copy and paste mistake from when this item was
first added. Use the definition in mlxplat_mlxcpld_msn201x_data so that
Clang no longer warns.

Link: ClangBuiltLinux#141
Fixes: a49a414 ("platform/x86: mlx-platform: Add support for new msn201x system type")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Acked-by: Vadim Pasternak <vadimp@mellanox.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
MellanoxBSP pushed a commit to Mellanox/hw-mgmt that referenced this issue Nov 28, 2019
@mellanoxbmc
hw-mgmt: v429 patchwork: Modify patch due to official back port work …
490e10b 
…for v4.10

The change due to the below commit has been introduced in v4.19:

commit 2103ebde9ac0fd1ae9efd08784778340902e2a3b
Author: Nathan Chancellor <natechancellor@gmail.com>
Date:   Tue Sep 25 22:21:15 2018 -0700

platform/x86: mlx-platform: Properly use mlxplat_mlxcpld_msn201x_items

[ Upstream commit 8289c4b6f2e53750de78bd38cecb6bce4d7a988c ]

 Clang warns that mlxplat_mlxcpld_msn201x_items is not going to be
 emitted in the final assembly because it's only used in ARRAY_SIZE right
 now, which is a compile time evaluation since the array's size is known.

 drivers/platform/x86/mlx-platform.c:555:32: warning: variable
 'mlxplat_mlxcpld_msn201x_items' is not needed and will not be emitted
[-Wunneeded-internal-declaration]
 static struct mlxreg_core_item mlxplat_mlxcpld_msn201x_items[] = {
                                   ^
 1 warning generated.

 It appears this was a copy and paste mistake from when this item was
 first added. Use the definition in mlxplat_mlxcpld_msn201x_data so that
 Clang no longer warns.

 Link: ClangBuiltLinux/linux#141
 Fixes: a49a41482f61 ("platform/x86: mlx-platform: Add support for new msn201x system type")
 Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
 Acked-by: Vadim Pasternak <vadimp@mellanox.com>
 Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

EOF

Signed-off-by: Vadim Pasternak <vadimp@mellanox.com>
ozohad pushed a commit to Mellanox/hw-mgmt that referenced this issue Nov 28, 2019
@mellanoxbmc @ozohad
hw-mgmt: v429 patchwork: Modify patch due to official back port work …
964fb8e 
…for v4.10

The change due to the below commit has been introduced in v4.19:

commit 2103ebde9ac0fd1ae9efd08784778340902e2a3b
Author: Nathan Chancellor <natechancellor@gmail.com>
Date:   Tue Sep 25 22:21:15 2018 -0700

platform/x86: mlx-platform: Properly use mlxplat_mlxcpld_msn201x_items

[ Upstream commit 8289c4b6f2e53750de78bd38cecb6bce4d7a988c ]

 Clang warns that mlxplat_mlxcpld_msn201x_items is not going to be
 emitted in the final assembly because it's only used in ARRAY_SIZE right
 now, which is a compile time evaluation since the array's size is known.

 drivers/platform/x86/mlx-platform.c:555:32: warning: variable
 'mlxplat_mlxcpld_msn201x_items' is not needed and will not be emitted
[-Wunneeded-internal-declaration]
 static struct mlxreg_core_item mlxplat_mlxcpld_msn201x_items[] = {
                                   ^
 1 warning generated.

 It appears this was a copy and paste mistake from when this item was
 first added. Use the definition in mlxplat_mlxcpld_msn201x_data so that
 Clang no longer warns.

 Link: ClangBuiltLinux/linux#141
 Fixes: a49a41482f61 ("platform/x86: mlx-platform: Add support for new msn201x system type")
 Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
 Acked-by: Vadim Pasternak <vadimp@mellanox.com>
 Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

EOF

Signed-off-by: Vadim Pasternak <vadimp@mellanox.com>
miraclestars pushed a commit to miraclestars/android_kernel_samsung_sm8250 that referenced this issue Aug 12, 2020
@nathanchance @miraclestars
platform/x86: mlx-platform: Properly use mlxplat_mlxcpld_msn201x_items
9d3279c 
[ Upstream commit 8289c4b6f2e53750de78bd38cecb6bce4d7a988c ]

Clang warns that mlxplat_mlxcpld_msn201x_items is not going to be
emitted in the final assembly because it's only used in ARRAY_SIZE right
now, which is a compile time evaluation since the array's size is known.

drivers/platform/x86/mlx-platform.c:555:32: warning: variable
'mlxplat_mlxcpld_msn201x_items' is not needed and will not be emitted
[-Wunneeded-internal-declaration]
static struct mlxreg_core_item mlxplat_mlxcpld_msn201x_items[] = {
                               ^
1 warning generated.

It appears this was a copy and paste mistake from when this item was
first added. Use the definition in mlxplat_mlxcpld_msn201x_data so that
Clang no longer warns.

Link: ClangBuiltLinux/linux#141
Fixes: a49a41482f61 ("platform/x86: mlx-platform: Add support for new msn201x system type")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Acked-by: Vadim Pasternak <vadimp@mellanox.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
miraclestars pushed a commit to miraclestars/android_kernel_samsung_sm8250 that referenced this issue Aug 12, 2020
@nathanchance @miraclestars
platform/x86: mlx-platform: Properly use mlxplat_mlxcpld_msn201x_items
2bc5418 
[ Upstream commit 8289c4b6f2e53750de78bd38cecb6bce4d7a988c ]

Clang warns that mlxplat_mlxcpld_msn201x_items is not going to be
emitted in the final assembly because it's only used in ARRAY_SIZE right
now, which is a compile time evaluation since the array's size is known.

drivers/platform/x86/mlx-platform.c:555:32: warning: variable
'mlxplat_mlxcpld_msn201x_items' is not needed and will not be emitted
[-Wunneeded-internal-declaration]
static struct mlxreg_core_item mlxplat_mlxcpld_msn201x_items[] = {
                               ^
1 warning generated.

It appears this was a copy and paste mistake from when this item was
first added. Use the definition in mlxplat_mlxcpld_msn201x_data so that
Clang no longer warns.

Link: ClangBuiltLinux/linux#141
Fixes: a49a41482f61 ("platform/x86: mlx-platform: Add support for new msn201x system type")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Acked-by: Vadim Pasternak <vadimp@mellanox.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
miraclestars pushed a commit to miraclestars/android_kernel_samsung_sm8250 that referenced this issue Aug 12, 2020
@nathanchance @miraclestars
platform/x86: mlx-platform: Properly use mlxplat_mlxcpld_msn201x_items
bbc2152 
[ Upstream commit 8289c4b6f2e53750de78bd38cecb6bce4d7a988c ]

Clang warns that mlxplat_mlxcpld_msn201x_items is not going to be
emitted in the final assembly because it's only used in ARRAY_SIZE right
now, which is a compile time evaluation since the array's size is known.

drivers/platform/x86/mlx-platform.c:555:32: warning: variable
'mlxplat_mlxcpld_msn201x_items' is not needed and will not be emitted
[-Wunneeded-internal-declaration]
static struct mlxreg_core_item mlxplat_mlxcpld_msn201x_items[] = {
                               ^
1 warning generated.

It appears this was a copy and paste mistake from when this item was
first added. Use the definition in mlxplat_mlxcpld_msn201x_data so that
Clang no longer warns.

Link: ClangBuiltLinux/linux#141
Fixes: a49a41482f61 ("platform/x86: mlx-platform: Add support for new msn201x system type")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Acked-by: Vadim Pasternak <vadimp@mellanox.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nathanchance nathanchance

Labels
-Wunneeded-internal-declaration [ARCH] x86_64 This bug impacts ARCH=x86_64 [BUG] linux A bug that should be fixed in the mainline kernel. [FIXED][LINUX] 4.20 This bug was fixed in Linux 4.20
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tpimh @nickdesaulniers @nathanchance