Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-Wpointer-bool-conversion in drivers/net/ethernet/asix/ax88796c_main.c #1492

Closed
nathanchance opened this issue Oct 25, 2021 · 2 comments
Closed

-Wpointer-bool-conversion in drivers/net/ethernet/asix/ax88796c_main.c #1492

nathanchance opened this issue Oct 25, 2021 · 2 comments
Assignees
@nathanchance
Labels
-Wpointer-bool-conversion [BUG] linux-next This is an issue only seen in linux-next [FIXED][LINUX] development cycle This bug was only present and fixed in a -next or -rc cycle

Comments

@nathanchance
Copy link
Member 

drivers/net/ethernet/asix/ax88796c_main.c:851:24: error: address of array 'ax_local->phydev->advertising' will always evaluate to 'true' [-Werror,-Wpointer-bool-conversion]
        if (ax_local->phydev->advertising &&
            ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~ ~~

Patch submitted: https://lore.kernel.org/r/20211025211238.178768-2-nathan@kernel.org/
@nathanchance nathanchance added -Wpointer-bool-conversion [PATCH] Submitted A patch has been submitted for review [BUG] linux-next This is an issue only seen in linux-next labels Oct 25, 2021
@nathanchance nathanchance self-assigned this Oct 25, 2021
@nathanchance
Copy link
Member Author

Patch accepted: https://git.kernel.org/netdev/net-next/c/971f5c4079ed

@nathanchance nathanchance added [PATCH] Accepted A submitted patch has been accepted upstream and removed [PATCH] Submitted A patch has been submitted for review labels Oct 26, 2021
idosch pushed a commit to jpirko/linux_mlxsw that referenced this issue Oct 26, 2021
@nathanchance @davem330
net: ax88796c: Remove pointless check in ax88796c_open()
971f5c4 
Clang warns:

drivers/net/ethernet/asix/ax88796c_main.c:851:24: error: address of
array 'ax_local->phydev->advertising' will always evaluate to 'true'
[-Werror,-Wpointer-bool-conversion]
        if (ax_local->phydev->advertising &&
            ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~ ~~

advertising cannot be NULL here if ax_local is not NULL, which cannot
happen due to the check in ax88796c_probe(). Remove the check.

Link: ClangBuiltLinux/linux#1492
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
@nathanchance nathanchance added [FIXED][LINUX] development cycle This bug was only present and fixed in a -next or -rc cycle and removed [PATCH] Accepted A submitted patch has been accepted upstream labels Oct 27, 2021
@nathanchance
Copy link
Member Author

Fixed in next-20211027.

LorenzoBianconi pushed a commit to LorenzoBianconi/mac80211-next that referenced this issue Nov 10, 2021
@nathanchance @LorenzoBianconi
net: ax88796c: Remove pointless check in ax88796c_open()
cc13799 
Clang warns:

drivers/net/ethernet/asix/ax88796c_main.c:851:24: error: address of
array 'ax_local->phydev->advertising' will always evaluate to 'true'
[-Werror,-Wpointer-bool-conversion]
        if (ax_local->phydev->advertising &&
            ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~ ~~

advertising cannot be NULL here if ax_local is not NULL, which cannot
happen due to the check in ax88796c_probe(). Remove the check.

Link: ClangBuiltLinux/linux#1492
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nathanchance nathanchance

Labels
-Wpointer-bool-conversion [BUG] linux-next This is an issue only seen in linux-next [FIXED][LINUX] development cycle This bug was only present and fixed in a -next or -rc cycle
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nathanchance