Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-Wuninitialized in drivers/net/ethernet/mellanox/mlx5/core/en/tc/sample.c #1494

Closed
nathanchance opened this issue Oct 27, 2021 · 2 comments
Closed

-Wuninitialized in drivers/net/ethernet/mellanox/mlx5/core/en/tc/sample.c #1494

nathanchance opened this issue Oct 27, 2021 · 2 comments
Assignees
@nathanchance
Labels
-Wuninitialized [BUG] linux-next This is an issue only seen in linux-next [FIXED][LINUX] development cycle This bug was only present and fixed in a -next or -rc cycle

Comments

@nathanchance
Copy link
Member 

drivers/net/ethernet/mellanox/mlx5/core/en/tc/sample.c:635:34: error: variable 'esw' is uninitialized when used here [-Werror,-Wuninitialized]
        mlx5_eswitch_del_offloaded_rule(esw, sample_flow->pre_rule, sample_flow->pre_attr);
                                        ^~~
drivers/net/ethernet/mellanox/mlx5/core/en/tc/sample.c:626:26: note: initialize the variable 'esw' to silence this warning
        struct mlx5_eswitch *esw;
                                ^
                                 = NULL
1 error generated.

Patch submitted: https://lore.kernel.org/r/20211027153122.3224673-1-nathan@kernel.org/
@nathanchance nathanchance added [PATCH] Submitted A patch has been submitted for review -Wuninitialized [BUG] linux-next This is an issue only seen in linux-next labels Oct 27, 2021
@nathanchance nathanchance self-assigned this Oct 27, 2021
@nathanchance
Copy link
Member Author

Accepted: https://git.kernel.org/netdev/net-next/c/1aec85974ab7

@nathanchance nathanchance added [PATCH] Accepted A submitted patch has been accepted upstream and removed [PATCH] Submitted A patch has been submitted for review labels Nov 1, 2021
w1ldptr pushed a commit to w1ldptr/linux that referenced this issue Nov 1, 2021
@nathanchance
net/mlx5: Add esw assignment back in mlx5e_tc_sample_unoffload()
7253f21 
Clang warns:

drivers/net/ethernet/mellanox/mlx5/core/en/tc/sample.c:635:34: error: variable 'esw' is uninitialized when used here [-Werror,-Wuninitialized]
        mlx5_eswitch_del_offloaded_rule(esw, sample_flow->pre_rule, sample_flow->pre_attr);
                                        ^~~
drivers/net/ethernet/mellanox/mlx5/core/en/tc/sample.c:626:26: note: initialize the variable 'esw' to silence this warning
        struct mlx5_eswitch *esw;
                                ^
                                 = NULL
1 error generated.

It appears that the assignment should have been shuffled instead of
removed outright like in mlx5e_tc_sample_offload(). Add it back so there
is no use of esw uninitialized.

Fixes: a64c5ed ("net/mlx5: Remove unnecessary checks for slow path flag")
Link: ClangBuiltLinux/linux#1494
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
@nathanchance
Copy link
Member Author

Merged into mainline: https://git.kernel.org/linus/1aec85974ab79903aaaab7d1f7fffe3d1ad1eee2

@nathanchance nathanchance added [FIXED][LINUX] development cycle This bug was only present and fixed in a -next or -rc cycle and removed [PATCH] Accepted A submitted patch has been accepted upstream labels Nov 2, 2021
oraclelinuxkernel pushed a commit to oracle/linux-uek that referenced this issue Dec 8, 2022
@nathanchance @jfvogel
net/mlx5: Add esw assignment back in mlx5e_tc_sample_unoffload()
a80d476 
Clang warns:

drivers/net/ethernet/mellanox/mlx5/core/en/tc/sample.c:635:34: error: variable 'esw' is uninitialized when used here [-Werror,-Wuninitialized]
        mlx5_eswitch_del_offloaded_rule(esw, sample_flow->pre_rule, sample_flow->pre_attr);
                                        ^~~
drivers/net/ethernet/mellanox/mlx5/core/en/tc/sample.c:626:26: note: initialize the variable 'esw' to silence this warning
        struct mlx5_eswitch *esw;
                                ^
                                 = NULL
1 error generated.

It appears that the assignment should have been shuffled instead of
removed outright like in mlx5e_tc_sample_offload(). Add it back so there
is no use of esw uninitialized.

Fixes: a64c5ed ("net/mlx5: Remove unnecessary checks for slow path flag")
Link: ClangBuiltLinux/linux#1494
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>

Orabug: 34481188

(cherry picked from commit 1aec859)
cherry-pick-repo=kernel/git/torvalds/linux.git
unmodified-from-upstream: 1aec859

Signed-off-by: Mikhael Goikhman <migo@nvidia.com>
Signed-off-by: Qing Huang <qing.huang@oracle.com>
Reviewed-by: Sharath Srinivasan <sharath.srinivasan@oracle.com>
(cherry picked from commit 19b0878456194a3a9ba61ac3a39b4ce83d00d5d8)
Signed-off-by: Jack Vogel <jack.vogel@oracle.com>
oraclelinuxkernel pushed a commit to oracle/linux-uek that referenced this issue Mar 6, 2023
@nathanchance @jfvogel
net/mlx5: Add esw assignment back in mlx5e_tc_sample_unoffload()
051abf5 
Clang warns:

drivers/net/ethernet/mellanox/mlx5/core/en/tc/sample.c:635:34: error: variable 'esw' is uninitialized when used here [-Werror,-Wuninitialized]
        mlx5_eswitch_del_offloaded_rule(esw, sample_flow->pre_rule, sample_flow->pre_attr);
                                        ^~~
drivers/net/ethernet/mellanox/mlx5/core/en/tc/sample.c:626:26: note: initialize the variable 'esw' to silence this warning
        struct mlx5_eswitch *esw;
                                ^
                                 = NULL
1 error generated.

It appears that the assignment should have been shuffled instead of
removed outright like in mlx5e_tc_sample_offload(). Add it back so there
is no use of esw uninitialized.

Fixes: a64c5ed ("net/mlx5: Remove unnecessary checks for slow path flag")
Link: ClangBuiltLinux/linux#1494
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>

Orabug: 34481188

(cherry picked from commit 1aec859)
cherry-pick-repo=kernel/git/torvalds/linux.git
unmodified-from-upstream: 1aec859

Signed-off-by: Mikhael Goikhman <migo@nvidia.com>
Signed-off-by: Qing Huang <qing.huang@oracle.com>
Reviewed-by: Sharath Srinivasan <sharath.srinivasan@oracle.com>
(cherry picked from commit 19b0878456194a3a9ba61ac3a39b4ce83d00d5d8)
Signed-off-by: Jack Vogel <jack.vogel@oracle.com>
oraclelinuxkernel pushed a commit to oracle/linux-uek that referenced this issue Mar 30, 2023
@nathanchance @jfvogel
net/mlx5: Add esw assignment back in mlx5e_tc_sample_unoffload()
3599c35 
Clang warns:

drivers/net/ethernet/mellanox/mlx5/core/en/tc/sample.c:635:34: error: variable 'esw' is uninitialized when used here [-Werror,-Wuninitialized]
        mlx5_eswitch_del_offloaded_rule(esw, sample_flow->pre_rule, sample_flow->pre_attr);
                                        ^~~
drivers/net/ethernet/mellanox/mlx5/core/en/tc/sample.c:626:26: note: initialize the variable 'esw' to silence this warning
        struct mlx5_eswitch *esw;
                                ^
                                 = NULL
1 error generated.

It appears that the assignment should have been shuffled instead of
removed outright like in mlx5e_tc_sample_offload(). Add it back so there
is no use of esw uninitialized.

Fixes: a64c5ed ("net/mlx5: Remove unnecessary checks for slow path flag")
Link: ClangBuiltLinux/linux#1494
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>

Orabug: 34481188

(cherry picked from commit 1aec859)
cherry-pick-repo=kernel/git/torvalds/linux.git
unmodified-from-upstream: 1aec859

Signed-off-by: Mikhael Goikhman <migo@nvidia.com>
Signed-off-by: Qing Huang <qing.huang@oracle.com>
Reviewed-by: Sharath Srinivasan <sharath.srinivasan@oracle.com>
(cherry picked from commit 19b0878456194a3a9ba61ac3a39b4ce83d00d5d8)
Signed-off-by: Jack Vogel <jack.vogel@oracle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nathanchance nathanchance

Labels
-Wuninitialized [BUG] linux-next This is an issue only seen in linux-next [FIXED][LINUX] development cycle This bug was only present and fixed in a -next or -rc cycle
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nathanchance