Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-Wenum-conversion in drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_v9.c #1596

Closed
nathanchance opened this issue Feb 17, 2022 · 2 comments
Closed

-Wenum-conversion in drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_v9.c #1596

nathanchance opened this issue Feb 17, 2022 · 2 comments
Assignees
@nathanchance
Labels
-Wenum-conversion [BUG] linux-next This is an issue only seen in linux-next [FIXED][LINUX] development cycle This bug was only present and fixed in a -next or -rc cycle

Comments

@nathanchance
Copy link
Member 

drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_packet_manager_v9.c:267:3: error: implicit conversion from enumeration type 'enum mes_map_queues_extended_engine_sel_enum' to different enumeration type 'enum mes_unmap_queues_extended_engine_sel_enum' [-Werror,-Wenum-conversion]
                extended_engine_sel__mes_map_queues__sdma0_to_7_sel :
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

Patch submitted: https://lore.kernel.org/r/20220217162142.1828990-1-nathan@kernel.org/
@nathanchance nathanchance added -Wenum-conversion [PATCH] Submitted A patch has been submitted for review [BUG] linux-next This is an issue only seen in linux-next labels Feb 17, 2022
@nathanchance nathanchance self-assigned this Feb 17, 2022
fengguang pushed a commit to 0day-ci/linux that referenced this issue Feb 17, 2022
@nathanchance @intel-lab-lkp
drm/amdkfd: Use proper enum in pm_unmap_queues_v9()
840067b 
Clang warns:

  drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_packet_manager_v9.c:267:3:
  error: implicit conversion from enumeration type 'enum
  mes_map_queues_extended_engine_sel_enum' to different enumeration type
  'enum mes_unmap_queues_extended_engine_sel_enum'
  [-Werror,-Wenum-conversion]
                  extended_engine_sel__mes_map_queues__sdma0_to_7_sel :
                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  1 error generated.

Use 'extended_engine_sel__mes_unmap_queues__sdma0_to_7_sel' to eliminate
the warning, which is the same numeric value of the proper type.

Fixes: 009e9a1 ("drm/amdkfd: navi2x requires extended engines to map and unmap sdma queues")
Link: ClangBuiltLinux#1596
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
@nathanchance nathanchance added [PATCH] Accepted A submitted patch has been accepted upstream and removed [PATCH] Submitted A patch has been submitted for review labels Feb 18, 2022
@nathanchance
Copy link
Member Author

Patch accepted: https://gitlab.freedesktop.org/agd5f/linux/-/commit/b63c54d978236dd6014cf2ffba96d626e97c915c

Jeoshua pushed a commit to Jeoshua/linux-hex that referenced this issue Feb 18, 2022
@nathanchance @alexdeucher
drm/amdkfd: Use proper enum in pm_unmap_queues_v9()
b63c54d 
Clang warns:

  drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_packet_manager_v9.c:267:3:
  error: implicit conversion from enumeration type 'enum
  mes_map_queues_extended_engine_sel_enum' to different enumeration type
  'enum mes_unmap_queues_extended_engine_sel_enum'
  [-Werror,-Wenum-conversion]
                  extended_engine_sel__mes_map_queues__sdma0_to_7_sel :
                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  1 error generated.

Use 'extended_engine_sel__mes_unmap_queues__sdma0_to_7_sel' to eliminate
the warning, which is the same numeric value of the proper type.

Fixes: 009e9a1 ("drm/amdkfd: navi2x requires extended engines to map and unmap sdma queues")
Link: ClangBuiltLinux/linux#1596
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
@nathanchance
Copy link
Member Author

Fixed in next-20220222: https://git.kernel.org/next/linux-next/c/b63c54d978236dd6014cf2ffba96d626e97c915c

@nathanchance nathanchance added [FIXED][LINUX] development cycle This bug was only present and fixed in a -next or -rc cycle and removed [PATCH] Accepted A submitted patch has been accepted upstream labels Feb 23, 2022
magalilemes pushed a commit to magalilemes/linux that referenced this issue Mar 21, 2022
@nathanchance @alexdeucher
drm/amdkfd: Use proper enum in pm_unmap_queues_v9()
823d564 
Clang warns:

  drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_packet_manager_v9.c:267:3:
  error: implicit conversion from enumeration type 'enum
  mes_map_queues_extended_engine_sel_enum' to different enumeration type
  'enum mes_unmap_queues_extended_engine_sel_enum'
  [-Werror,-Wenum-conversion]
                  extended_engine_sel__mes_map_queues__sdma0_to_7_sel :
                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  1 error generated.

Use 'extended_engine_sel__mes_unmap_queues__sdma0_to_7_sel' to eliminate
the warning, which is the same numeric value of the proper type.

Fixes: 009e9a1 ("drm/amdkfd: navi2x requires extended engines to map and unmap sdma queues")
Link: ClangBuiltLinux#1596
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nathanchance nathanchance

Labels
-Wenum-conversion [BUG] linux-next This is an issue only seen in linux-next [FIXED][LINUX] development cycle This bug was only present and fixed in a -next or -rc cycle
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nathanchance