CFI failure target: simpledrm_simple_display_pipe_mode_valid #1647

tpgxyz · 2022-05-30T21:45:35Z

Hello team,
looks like simpledrm does not pass over Clang CFI schemes.

[tpg@omv-rockpro64 ~]$ uname -a
Linux omv-rockpro64 5.18.0-server-clang-1omv4090 #1 SMP PREEMPT_DYNAMIC Mon May 30 15:21:52 UTC 2022 aarch64 aarch64 aarch64 GNU/Linux

Kernel is compiled with LLVM-14.0.0. Well i noticed that with kernel 5.16.x, however now i found time to trigger this and file an issue. Good luck :)

Sources:
https://github.com/OpenMandrivaAssociation/llvm
https://github.com/OpenMandrivaAssociation/kernel-release

[tpg@omv-rockpro64 /home/tpg]# cat /etc/os-release                                                                                                                                                                                                                           
NAME="OpenMandriva Lx"
VERSION="4.90 (Nickel) Cooker"
ID="openmandriva"
VERSION_ID="4.90"
PRETTY_NAME="OpenMandriva Lx 4.90 (Nickel) Cooker"
BUILD_ID="20220508.17"
VERSION_CODENAME="nickel"
ANSI_COLOR="1;43"
LOGO="openmandriva"
CPE_NAME="cpe:/o:openmandriva:openmandriva_lx:4.90"
HOME_URL="http://openmandriva.org/"
BUG_REPORT_URL="http://issues.openmandriva.org/"
SUPPORT_URL="https://forum.openmandriva.org"
PRIVACY_POLICY_URL="https://www.openmandriva.org/tos"

[Mon May 30 23:33:42 2022] [drm] Initialized simpledrm 1.0.0 20200625 for simple-framebuffer.0 on minor 0
[Mon May 30 23:33:42 2022] ------------[ cut here ]------------
[Mon May 30 23:33:42 2022] CFI failure (target: simpledrm_simple_display_pipe_mode_valid+0x0/0x8):
[Mon May 30 23:33:42 2022] WARNING: CPU: 5 PID: 1 at __ubsan_handle_cfi_check_fail+0x58/0x60
[Mon May 30 23:33:42 2022] Modules linked in:
[Mon May 30 23:33:42 2022] CPU: 5 PID: 1 Comm: swapper/0 Not tainted 5.18.0-server-clang-1omv4090 #1 0bab7c08822605d10172e39c60a63385c0513874
[Mon May 30 23:33:42 2022] Hardware name: Unknown Unknown Product/Unknown Product, BIOS 2022.04 04/01/2022
[Mon May 30 23:33:42 2022] pstate: 60400005 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--)
[Mon May 30 23:33:42 2022] pc : __ubsan_handle_cfi_check_fail+0x58/0x60
[Mon May 30 23:33:42 2022] lr : __ubsan_handle_cfi_check_fail+0x58/0x60
[Mon May 30 23:33:42 2022] sp : ffff80000804b390
[Mon May 30 23:33:42 2022] x29: ffff80000804b390 x28: ffff61a2eb4d1270 x27: ffff61a2eb4d1240
[Mon May 30 23:33:42 2022] x26: ffffa969163b4188 x25: ffff61a2eb4d1200 x24: ffff61a207d5f260
[Mon May 30 23:33:42 2022] x23: ffffa969151e1000 x22: ffff61a207d5ebd0 x21: 95367310a8c1a0c2
[Mon May 30 23:33:42 2022] x20: ffffa96917d56210 x19: ffffa969163b7618 x18: ffffffffffffffff
[Mon May 30 23:33:42 2022] x17: 78302b64696c6176 x16: 00000000ffffc000 x15: 0000000000000004
[Mon May 30 23:33:42 2022] x14: 0000000000003fff x13: ffff61a2f5530bc0 x12: 0000000000000003
[Mon May 30 23:33:42 2022] x11: 00000000ffffbfff x10: c0000000ffffbfff x9 : 0f398a9dd8c04100
[Mon May 30 23:33:42 2022] x8 : 0f398a9dd8c04100 x7 : 7261742820657275 x6 : 6c69616620494643
[Mon May 30 23:33:42 2022] x5 : ffffa96917e42dc0 x4 : 0000000000000001 x3 : 0000000000000000
[Mon May 30 23:33:42 2022] x2 : 0000000000000000 x1 : ffffa96916c7f005 x0 : 0000000000000047
[Mon May 30 23:33:42 2022] Call trace:
[Mon May 30 23:33:42 2022]  __ubsan_handle_cfi_check_fail+0x58/0x60
[Mon May 30 23:33:42 2022]  __cfi_check_fail+0x3c/0x44
[Mon May 30 23:33:42 2022]  __cfi_slowpath_diag+0x158/0x1a4
[Mon May 30 23:33:42 2022]  drm_simple_kms_crtc_mode_valid+0x58/0x80
[Mon May 30 23:33:42 2022]  drm_helper_probe_single_connector_modes+0x6f8/0xa0c
[Mon May 30 23:33:42 2022]  drm_client_modeset_probe+0x1bc/0x1364
[Mon May 30 23:33:42 2022]  __drm_fb_helper_initial_config_and_unlock+0x58/0x5f4
[Mon May 30 23:33:42 2022]  drm_fbdev_client_hotplug+0x150/0x1c8
[Mon May 30 23:33:42 2022]  drm_fbdev_generic_setup+0xa0/0x180
[Mon May 30 23:33:42 2022]  simpledrm_probe+0x114/0xc30
[Mon May 30 23:33:42 2022]  platform_probe+0xcc/0x118
[Mon May 30 23:33:42 2022]  really_probe+0x1d0/0x428
[Mon May 30 23:33:42 2022]  __driver_probe_device+0xc0/0xec
[Mon May 30 23:33:42 2022]  driver_probe_device+0x4c/0x244
[Mon May 30 23:33:42 2022]  __device_attach_driver+0x130/0x188
[Mon May 30 23:33:42 2022]  bus_for_each_drv+0xa8/0x150
[Mon May 30 23:33:42 2022]  __device_attach+0x114/0x194
[Mon May 30 23:33:42 2022]  bus_probe_device+0x4c/0x104
[Mon May 30 23:33:42 2022]  device_add+0x3c0/0x6c8
[Mon May 30 23:33:42 2022]  platform_device_add+0x90/0x234
[Mon May 30 23:33:42 2022]  sysfb_create_simplefb+0xf8/0x164
[Mon May 30 23:33:42 2022]  sysfb_init+0x50/0x10c
[Mon May 30 23:33:42 2022]  __initstub__kmod_sysfb__418_83_sysfb_init6+0x1c/0x28
[Mon May 30 23:33:42 2022]  do_one_initcall+0xd0/0x3f8
[Mon May 30 23:33:42 2022]  do_initcall_level+0xb8/0x1bc
[Mon May 30 23:33:42 2022]  do_initcalls+0x60/0xa0
[Mon May 30 23:33:42 2022]  do_basic_setup+0x28/0x34
[Mon May 30 23:33:42 2022]  kernel_init_freeable+0xf4/0x164
[Mon May 30 23:33:42 2022]  kernel_init+0x2c/0x1c4
[Mon May 30 23:33:42 2022]  ret_from_fork+0x10/0x20
[Mon May 30 23:33:42 2022] ---[ end trace 0000000000000000 ]---
[Mon May 30 23:33:42 2022] ------------[ cut here ]------------
[Mon May 30 23:33:42 2022] CFI failure (target: simpledrm_simple_display_pipe_mode_valid+0x0/0x8):
[Mon May 30 23:33:42 2022] WARNING: CPU: 5 PID: 1 at __ubsan_handle_cfi_check_fail+0x58/0x60
[Mon May 30 23:33:42 2022] Modules linked in:
[Mon May 30 23:33:42 2022] CPU: 5 PID: 1 Comm: swapper/0 Tainted: G        W         5.18.0-server-clang-1omv4090 #1 0bab7c08822605d10172e39c60a63385c0513874
[Mon May 30 23:33:42 2022] Hardware name: Unknown Unknown Product/Unknown Product, BIOS 2022.04 04/01/2022
[Mon May 30 23:33:42 2022] pstate: 60400005 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--)
[Mon May 30 23:33:42 2022] pc : __ubsan_handle_cfi_check_fail+0x58/0x60
[Mon May 30 23:33:42 2022] lr : __ubsan_handle_cfi_check_fail+0x58/0x60
[Mon May 30 23:33:42 2022] sp : ffff80000804b0a0
[Mon May 30 23:33:42 2022] x29: ffff80000804b0a0 x28: 000000000000006e x27: ffff61a207d5e6e8
[Mon May 30 23:33:42 2022] x26: 000000000000000a x25: 0000000000000038 x24: 0000000000000000
[Mon May 30 23:33:42 2022] x23: ffffa969151e1000 x22: ffff61a2014eb690 x21: 95367310a8c1a0c2
[Mon May 30 23:33:42 2022] x20: ffffa96917d56210 x19: ffffa969163b7618 x18: ffff61a2eaf2b780
[Mon May 30 23:33:42 2022] x17: 0000000000000000 x16: 00000000000000e4 x15: ffffa96915a736c0
[Mon May 30 23:33:42 2022] x14: 0000000000000001 x13: 0000000000000000 x12: 0000000000000000
[Mon May 30 23:33:42 2022] x11: 00000000ffffffff x10: 0000000100000001 x9 : 0f398a9dd8c04100
[Mon May 30 23:33:42 2022] x8 : 0f398a9dd8c04100 x7 : 7f7f7f7f7f7f7f7f x6 : 0000000000000029
[Mon May 30 23:33:42 2022] x5 : ffff61a2f56f5830 x4 : ffffa96916bf957a x3 : ffff0a00ffffff05
[Mon May 30 23:33:42 2022] x2 : 80000000ffffc12f x1 : 0000000000000000 x0 : 0000000000000047
[Mon May 30 23:33:42 2022] Call trace:
[Mon May 30 23:33:42 2022]  __ubsan_handle_cfi_check_fail+0x58/0x60
[Mon May 30 23:33:42 2022]  __cfi_check_fail+0x3c/0x44
[Mon May 30 23:33:42 2022]  __cfi_slowpath_diag+0x158/0x1a4
[Mon May 30 23:33:42 2022]  drm_simple_kms_crtc_mode_valid+0x58/0x80
[Mon May 30 23:33:42 2022]  drm_crtc_mode_valid+0x40/0x8c
[Mon May 30 23:33:42 2022]  drm_atomic_helper_check_modeset+0xa78/0xee4
[Mon May 30 23:33:42 2022]  drm_atomic_helper_check+0x28/0x9c
[Mon May 30 23:33:42 2022]  drm_atomic_check_only+0x558/0xb38
[Mon May 30 23:33:42 2022]  drm_atomic_commit+0x28/0xc0
[Mon May 30 23:33:42 2022]  drm_client_modeset_commit_atomic+0x290/0x368
[Mon May 30 23:33:42 2022]  drm_client_modeset_commit_locked+0x60/0x1cc
[Mon May 30 23:33:42 2022]  drm_client_modeset_commit+0x38/0x60
[Mon May 30 23:33:42 2022]  drm_fb_helper_set_par+0x80/0xec
[Mon May 30 23:33:42 2022]  fbcon_init+0x33c/0x598
[Mon May 30 23:33:42 2022]  visual_init+0xd8/0x14c
[Mon May 30 23:33:42 2022]  do_bind_con_driver+0x484/0x5c8
[Mon May 30 23:33:42 2022]  do_take_over_console+0x470/0x500
[Mon May 30 23:33:42 2022]  fbcon_fb_registered+0x1a0/0x27c
[Mon May 30 23:33:42 2022]  do_register_framebuffer+0x47c/0x560
[Mon May 30 23:33:42 2022]  register_framebuffer+0x38/0x58
[Mon May 30 23:33:42 2022]  __drm_fb_helper_initial_config_and_unlock+0x440/0x5f4
[Mon May 30 23:33:42 2022]  drm_fbdev_client_hotplug+0x150/0x1c8
[Mon May 30 23:33:42 2022]  drm_fbdev_generic_setup+0xa0/0x180
[Mon May 30 23:33:42 2022]  simpledrm_probe+0x114/0xc30
[Mon May 30 23:33:42 2022]  platform_probe+0xcc/0x118
[Mon May 30 23:33:42 2022]  really_probe+0x1d0/0x428
[Mon May 30 23:33:42 2022]  __driver_probe_device+0xc0/0xec
[Mon May 30 23:33:42 2022]  driver_probe_device+0x4c/0x244
[Mon May 30 23:33:42 2022]  __device_attach_driver+0x130/0x188
[Mon May 30 23:33:42 2022]  bus_for_each_drv+0xa8/0x150
[Mon May 30 23:33:42 2022]  __device_attach+0x114/0x194
[Mon May 30 23:33:42 2022]  bus_probe_device+0x4c/0x104
[Mon May 30 23:33:42 2022]  device_add+0x3c0/0x6c8
[Mon May 30 23:33:42 2022]  platform_device_add+0x90/0x234
[Mon May 30 23:33:42 2022]  sysfb_create_simplefb+0xf8/0x164
[Mon May 30 23:33:42 2022]  sysfb_init+0x50/0x10c
[Mon May 30 23:33:42 2022]  __initstub__kmod_sysfb__418_83_sysfb_init6+0x1c/0x28
[Mon May 30 23:33:42 2022]  do_one_initcall+0xd0/0x3f8
[Mon May 30 23:33:42 2022]  do_initcall_level+0xb8/0x1bc
[Mon May 30 23:33:42 2022]  do_initcalls+0x60/0xa0
[Mon May 30 23:33:42 2022]  do_basic_setup+0x28/0x34
[Mon May 30 23:33:42 2022]  kernel_init_freeable+0xf4/0x164
[Mon May 30 23:33:42 2022]  kernel_init+0x2c/0x1c4
[Mon May 30 23:33:42 2022]  ret_from_fork+0x10/0x20
[Mon May 30 23:33:42 2022] ---[ end trace 0000000000000000 ]---
[Mon May 30 23:33:42 2022] Console: switching to colour frame buffer device 240x67
[Mon May 30 23:33:42 2022] simple-framebuffer simple-framebuffer.0: [drm] fb0: simpledrmdrmfb frame buffer device

The text was updated successfully, but these errors were encountered:

nathanchance · 2022-05-31T01:53:42Z

Does this help?

diff --git a/drivers/gpu/drm/tiny/simpledrm.c b/drivers/gpu/drm/tiny/simpledrm.c
index 768242a78e2b..5422363690e7 100644
--- a/drivers/gpu/drm/tiny/simpledrm.c
+++ b/drivers/gpu/drm/tiny/simpledrm.c
@@ -627,7 +627,7 @@ static const struct drm_connector_funcs simpledrm_connector_funcs = {
        .atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
 };

-static int
+static enum drm_mode_status
 simpledrm_simple_display_pipe_mode_valid(struct drm_simple_display_pipe *pipe,
                                    const struct drm_display_mode *mode)
 {

tpgxyz · 2022-06-07T08:04:02Z

@nathanchance Thanks, will take a look on this, nevertheless i'm blocked with #1649

nathanchance · 2022-07-25T23:37:57Z

I can reproduce this in a virtual machine on my MacBook Air and I can confirm that my diff above resolves the failure.

Patch sent: https://lore.kernel.org/20220725233629.223223-1-nathan@kernel.org/

…valid() When booting a kernel compiled with clang's CFI protection (CONFIG_CFI_CLANG), there is a CFI failure in drm_simple_kms_crtc_mode_valid() when trying to call simpledrm_simple_display_pipe_mode_valid() through ->mode_valid(): [ 0.322802] CFI failure (target: simpledrm_simple_display_pipe_mode_valid+0x0/0x8): ... [ 0.324928] Call trace: [ 0.324969] __ubsan_handle_cfi_check_fail+0x58/0x60 [ 0.325053] __cfi_check_fail+0x3c/0x44 [ 0.325120] __cfi_slowpath_diag+0x178/0x200 [ 0.325192] drm_simple_kms_crtc_mode_valid+0x58/0x80 [ 0.325279] __drm_helper_update_and_validate+0x31c/0x464 ... The ->mode_valid() member in 'struct drm_simple_display_pipe_funcs' expects a return type of 'enum drm_mode_status', not 'int'. Correct it to fix the CFI failure. Cc: stable@vger.kernel.org Fixes: 11e8f5f ("drm: Add simpledrm driver") Link: ClangBuiltLinux#1647 Reported-by: Tomasz Paweł Gajc <tpgxyz@gmail.com> Signed-off-by: Nathan Chancellor <nathan@kernel.org>

nathanchance · 2022-07-26T15:59:05Z

Patch accepted: https://cgit.freedesktop.org/drm/drm-misc/commit/?id=0c09bc33aa8e9dc867300acaadc318c2f0d85a1e

nathanchance · 2022-07-29T20:45:28Z

Merged into mainline: https://git.kernel.org/linus/0c09bc33aa8e9dc867300acaadc318c2f0d85a1e

It should get backported to stable automatically due to the Cc: stable@vger.kernel.org.

…valid() commit 0c09bc3 upstream. When booting a kernel compiled with clang's CFI protection (CONFIG_CFI_CLANG), there is a CFI failure in drm_simple_kms_crtc_mode_valid() when trying to call simpledrm_simple_display_pipe_mode_valid() through ->mode_valid(): [ 0.322802] CFI failure (target: simpledrm_simple_display_pipe_mode_valid+0x0/0x8): ... [ 0.324928] Call trace: [ 0.324969] __ubsan_handle_cfi_check_fail+0x58/0x60 [ 0.325053] __cfi_check_fail+0x3c/0x44 [ 0.325120] __cfi_slowpath_diag+0x178/0x200 [ 0.325192] drm_simple_kms_crtc_mode_valid+0x58/0x80 [ 0.325279] __drm_helper_update_and_validate+0x31c/0x464 ... The ->mode_valid() member in 'struct drm_simple_display_pipe_funcs' expects a return type of 'enum drm_mode_status', not 'int'. Correct it to fix the CFI failure. Cc: stable@vger.kernel.org Fixes: 11e8f5f ("drm: Add simpledrm driver") Link: ClangBuiltLinux/linux#1647 Reported-by: Tomasz Paweł Gajc <tpgxyz@gmail.com> Signed-off-by: Nathan Chancellor <nathan@kernel.org> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Reviewed-by: Sami Tolvanen <samitolvanen@google.com> Link: https://patchwork.freedesktop.org/patch/msgid/20220725233629.223223-1-nathan@kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

…valid() commit 0c09bc3 upstream. When booting a kernel compiled with clang's CFI protection (CONFIG_CFI_CLANG), there is a CFI failure in drm_simple_kms_crtc_mode_valid() when trying to call simpledrm_simple_display_pipe_mode_valid() through ->mode_valid(): [ 0.322802] CFI failure (target: simpledrm_simple_display_pipe_mode_valid+0x0/0x8): ... [ 0.324928] Call trace: [ 0.324969] __ubsan_handle_cfi_check_fail+0x58/0x60 [ 0.325053] __cfi_check_fail+0x3c/0x44 [ 0.325120] __cfi_slowpath_diag+0x178/0x200 [ 0.325192] drm_simple_kms_crtc_mode_valid+0x58/0x80 [ 0.325279] __drm_helper_update_and_validate+0x31c/0x464 ... The ->mode_valid() member in 'struct drm_simple_display_pipe_funcs' expects a return type of 'enum drm_mode_status', not 'int'. Correct it to fix the CFI failure. Cc: stable@vger.kernel.org Fixes: 11e8f5f ("drm: Add simpledrm driver") Link: ClangBuiltLinux#1647 Reported-by: Tomasz Paweł Gajc <tpgxyz@gmail.com> Signed-off-by: Nathan Chancellor <nathan@kernel.org> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Reviewed-by: Sami Tolvanen <samitolvanen@google.com> Link: https://patchwork.freedesktop.org/patch/msgid/20220725233629.223223-1-nathan@kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

…valid() commit 0c09bc3 upstream. When booting a kernel compiled with clang's CFI protection (CONFIG_CFI_CLANG), there is a CFI failure in drm_simple_kms_crtc_mode_valid() when trying to call simpledrm_simple_display_pipe_mode_valid() through ->mode_valid(): [ 0.322802] CFI failure (target: simpledrm_simple_display_pipe_mode_valid+0x0/0x8): ... [ 0.324928] Call trace: [ 0.324969] __ubsan_handle_cfi_check_fail+0x58/0x60 [ 0.325053] __cfi_check_fail+0x3c/0x44 [ 0.325120] __cfi_slowpath_diag+0x178/0x200 [ 0.325192] drm_simple_kms_crtc_mode_valid+0x58/0x80 [ 0.325279] __drm_helper_update_and_validate+0x31c/0x464 ... The ->mode_valid() member in 'struct drm_simple_display_pipe_funcs' expects a return type of 'enum drm_mode_status', not 'int'. Correct it to fix the CFI failure. Cc: stable@vger.kernel.org Fixes: 11e8f5f ("drm: Add simpledrm driver") Link: ClangBuiltLinux/linux#1647 Reported-by: Tomasz Paweł Gajc <tpgxyz@gmail.com> Signed-off-by: Nathan Chancellor <nathan@kernel.org> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Reviewed-by: Sami Tolvanen <samitolvanen@google.com> Link: https://patchwork.freedesktop.org/patch/msgid/20220725233629.223223-1-nathan@kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

…valid() commit 0c09bc3 upstream. When booting a kernel compiled with clang's CFI protection (CONFIG_CFI_CLANG), there is a CFI failure in drm_simple_kms_crtc_mode_valid() when trying to call simpledrm_simple_display_pipe_mode_valid() through ->mode_valid(): [ 0.322802] CFI failure (target: simpledrm_simple_display_pipe_mode_valid+0x0/0x8): ... [ 0.324928] Call trace: [ 0.324969] __ubsan_handle_cfi_check_fail+0x58/0x60 [ 0.325053] __cfi_check_fail+0x3c/0x44 [ 0.325120] __cfi_slowpath_diag+0x178/0x200 [ 0.325192] drm_simple_kms_crtc_mode_valid+0x58/0x80 [ 0.325279] __drm_helper_update_and_validate+0x31c/0x464 ... The ->mode_valid() member in 'struct drm_simple_display_pipe_funcs' expects a return type of 'enum drm_mode_status', not 'int'. Correct it to fix the CFI failure. Cc: stable@vger.kernel.org Fixes: 11e8f5f ("drm: Add simpledrm driver") Link: ClangBuiltLinux#1647 Reported-by: Tomasz Paweł Gajc <tpgxyz@gmail.com> Signed-off-by: Nathan Chancellor <nathan@kernel.org> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Reviewed-by: Sami Tolvanen <samitolvanen@google.com> Link: https://patchwork.freedesktop.org/patch/msgid/20220725233629.223223-1-nathan@kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

…valid() commit 0c09bc3 upstream. When booting a kernel compiled with clang's CFI protection (CONFIG_CFI_CLANG), there is a CFI failure in drm_simple_kms_crtc_mode_valid() when trying to call simpledrm_simple_display_pipe_mode_valid() through ->mode_valid(): [ 0.322802] CFI failure (target: simpledrm_simple_display_pipe_mode_valid+0x0/0x8): ... [ 0.324928] Call trace: [ 0.324969] __ubsan_handle_cfi_check_fail+0x58/0x60 [ 0.325053] __cfi_check_fail+0x3c/0x44 [ 0.325120] __cfi_slowpath_diag+0x178/0x200 [ 0.325192] drm_simple_kms_crtc_mode_valid+0x58/0x80 [ 0.325279] __drm_helper_update_and_validate+0x31c/0x464 ... The ->mode_valid() member in 'struct drm_simple_display_pipe_funcs' expects a return type of 'enum drm_mode_status', not 'int'. Correct it to fix the CFI failure. Cc: stable@vger.kernel.org Fixes: 11e8f5f ("drm: Add simpledrm driver") Link: ClangBuiltLinux/linux#1647 Reported-by: Tomasz Paweł Gajc <tpgxyz@gmail.com> Signed-off-by: Nathan Chancellor <nathan@kernel.org> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Reviewed-by: Sami Tolvanen <samitolvanen@google.com> Link: https://patchwork.freedesktop.org/patch/msgid/20220725233629.223223-1-nathan@kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

…valid() commit 0c09bc33aa8e9dc867300acaadc318c2f0d85a1e upstream. When booting a kernel compiled with clang's CFI protection (CONFIG_CFI_CLANG), there is a CFI failure in drm_simple_kms_crtc_mode_valid() when trying to call simpledrm_simple_display_pipe_mode_valid() through ->mode_valid(): [ 0.322802] CFI failure (target: simpledrm_simple_display_pipe_mode_valid+0x0/0x8): ... [ 0.324928] Call trace: [ 0.324969] __ubsan_handle_cfi_check_fail+0x58/0x60 [ 0.325053] __cfi_check_fail+0x3c/0x44 [ 0.325120] __cfi_slowpath_diag+0x178/0x200 [ 0.325192] drm_simple_kms_crtc_mode_valid+0x58/0x80 [ 0.325279] __drm_helper_update_and_validate+0x31c/0x464 ... The ->mode_valid() member in 'struct drm_simple_display_pipe_funcs' expects a return type of 'enum drm_mode_status', not 'int'. Correct it to fix the CFI failure. Cc: stable@vger.kernel.org Fixes: 11e8f5f ("drm: Add simpledrm driver") Link: ClangBuiltLinux/linux#1647 Reported-by: Tomasz Paweł Gajc <tpgxyz@gmail.com> Signed-off-by: Nathan Chancellor <nathan@kernel.org> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Reviewed-by: Sami Tolvanen <samitolvanen@google.com> Link: https://patchwork.freedesktop.org/patch/msgid/20220725233629.223223-1-nathan@kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

…valid() BugLink: https://bugs.launchpad.net/bugs/1989218 commit 0c09bc33aa8e9dc867300acaadc318c2f0d85a1e upstream. When booting a kernel compiled with clang's CFI protection (CONFIG_CFI_CLANG), there is a CFI failure in drm_simple_kms_crtc_mode_valid() when trying to call simpledrm_simple_display_pipe_mode_valid() through ->mode_valid(): [ 0.322802] CFI failure (target: simpledrm_simple_display_pipe_mode_valid+0x0/0x8): ... [ 0.324928] Call trace: [ 0.324969] __ubsan_handle_cfi_check_fail+0x58/0x60 [ 0.325053] __cfi_check_fail+0x3c/0x44 [ 0.325120] __cfi_slowpath_diag+0x178/0x200 [ 0.325192] drm_simple_kms_crtc_mode_valid+0x58/0x80 [ 0.325279] __drm_helper_update_and_validate+0x31c/0x464 ... The ->mode_valid() member in 'struct drm_simple_display_pipe_funcs' expects a return type of 'enum drm_mode_status', not 'int'. Correct it to fix the CFI failure. Cc: stable@vger.kernel.org Fixes: 11e8f5f ("drm: Add simpledrm driver") Link: ClangBuiltLinux/linux#1647 Reported-by: Tomasz Paweł Gajc <tpgxyz@gmail.com> Signed-off-by: Nathan Chancellor <nathan@kernel.org> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Reviewed-by: Sami Tolvanen <samitolvanen@google.com> Link: https://patchwork.freedesktop.org/patch/msgid/20220725233629.223223-1-nathan@kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Kamal Mostafa <kamal@canonical.com> Signed-off-by: Stefan Bader <stefan.bader@canonical.com>

…valid() BugLink: https://bugs.launchpad.net/bugs/1989218 commit 0c09bc3 upstream. When booting a kernel compiled with clang's CFI protection (CONFIG_CFI_CLANG), there is a CFI failure in drm_simple_kms_crtc_mode_valid() when trying to call simpledrm_simple_display_pipe_mode_valid() through ->mode_valid(): [ 0.322802] CFI failure (target: simpledrm_simple_display_pipe_mode_valid+0x0/0x8): ... [ 0.324928] Call trace: [ 0.324969] __ubsan_handle_cfi_check_fail+0x58/0x60 [ 0.325053] __cfi_check_fail+0x3c/0x44 [ 0.325120] __cfi_slowpath_diag+0x178/0x200 [ 0.325192] drm_simple_kms_crtc_mode_valid+0x58/0x80 [ 0.325279] __drm_helper_update_and_validate+0x31c/0x464 ... The ->mode_valid() member in 'struct drm_simple_display_pipe_funcs' expects a return type of 'enum drm_mode_status', not 'int'. Correct it to fix the CFI failure. Cc: stable@vger.kernel.org Fixes: 11e8f5f ("drm: Add simpledrm driver") Link: ClangBuiltLinux/linux#1647 Reported-by: Tomasz Paweł Gajc <tpgxyz@gmail.com> Signed-off-by: Nathan Chancellor <nathan@kernel.org> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Reviewed-by: Sami Tolvanen <samitolvanen@google.com> Link: https://patchwork.freedesktop.org/patch/msgid/20220725233629.223223-1-nathan@kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Kamal Mostafa <kamal@canonical.com> Signed-off-by: Stefan Bader <stefan.bader@canonical.com>

…valid() When booting a kernel compiled with clang's CFI protection (CONFIG_CFI_CLANG), there is a CFI failure in drm_simple_kms_crtc_mode_valid() when trying to call simpledrm_simple_display_pipe_mode_valid() through ->mode_valid(): [ 0.322802] CFI failure (target: simpledrm_simple_display_pipe_mode_valid+0x0/0x8): ... [ 0.324928] Call trace: [ 0.324969] __ubsan_handle_cfi_check_fail+0x58/0x60 [ 0.325053] __cfi_check_fail+0x3c/0x44 [ 0.325120] __cfi_slowpath_diag+0x178/0x200 [ 0.325192] drm_simple_kms_crtc_mode_valid+0x58/0x80 [ 0.325279] __drm_helper_update_and_validate+0x31c/0x464 ... The ->mode_valid() member in 'struct drm_simple_display_pipe_funcs' expects a return type of 'enum drm_mode_status', not 'int'. Correct it to fix the CFI failure. Cc: stable@vger.kernel.org Fixes: 11e8f5f ("drm: Add simpledrm driver") Link: ClangBuiltLinux#1647 Reported-by: Tomasz Paweł Gajc <tpgxyz@gmail.com> Signed-off-by: Nathan Chancellor <nathan@kernel.org> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Reviewed-by: Sami Tolvanen <samitolvanen@google.com> Link: https://patchwork.freedesktop.org/patch/msgid/20220725233629.223223-1-nathan@kernel.org (cherry picked from commit 0c09bc3) Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>

nickdesaulniers added [PATCH] Exists There is a patch that fixes this issue more info needed More information requested to issue author from project members. [ARCH] arm64 This bug impacts ARCH=arm64 [BUG] linux A bug that should be fixed in the mainline kernel. labels May 31, 2022

nathanchance added the [FEATURE] CFI Related to building the kernel with Clang Control Flow Integrity label May 31, 2022

nathanchance added [PATCH] Submitted A patch has been submitted for review and removed [PATCH] Exists There is a patch that fixes this issue labels Jul 25, 2022

nathanchance self-assigned this Jul 25, 2022

nathanchance removed the more info needed More information requested to issue author from project members. label Jul 25, 2022

nathanchance added [PATCH] Accepted A submitted patch has been accepted upstream and removed [PATCH] Submitted A patch has been submitted for review labels Jul 26, 2022

nathanchance closed this as completed Jul 29, 2022

nathanchance added [FIXED][LINUX] 5.19 This bug was fixed in Linux 5.19 and removed [PATCH] Accepted A submitted patch has been accepted upstream labels Jul 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CFI failure target: simpledrm_simple_display_pipe_mode_valid #1647

CFI failure target: simpledrm_simple_display_pipe_mode_valid #1647

tpgxyz commented May 30, 2022 •

edited

Loading

nathanchance commented May 31, 2022

tpgxyz commented Jun 7, 2022

nathanchance commented Jul 25, 2022

nathanchance commented Jul 26, 2022

nathanchance commented Jul 29, 2022

CFI failure target: simpledrm_simple_display_pipe_mode_valid #1647

CFI failure target: simpledrm_simple_display_pipe_mode_valid #1647

Comments

tpgxyz commented May 30, 2022 • edited Loading

nathanchance commented May 31, 2022

tpgxyz commented Jun 7, 2022

nathanchance commented Jul 25, 2022

nathanchance commented Jul 26, 2022

nathanchance commented Jul 29, 2022

tpgxyz commented May 30, 2022 •

edited

Loading