Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-Wuninitialized in sound/soc/amd/acp/acp-platform.c #1675

Closed
nathanchance opened this issue Jul 25, 2022 · 2 comments
Closed

-Wuninitialized in sound/soc/amd/acp/acp-platform.c #1675

nathanchance opened this issue Jul 25, 2022 · 2 comments
Assignees
@nathanchance
Labels
-Wuninitialized [BUG] linux-next This is an issue only seen in linux-next [FIXED][LINUX] development cycle This bug was only present and fixed in a -next or -rc cycle

Comments

@nathanchance
Copy link
Member 

../sound/soc/amd/acp/acp-platform.c:117:19: error: variable 'ext_intr_stat1' is uninitialized when used here [-Werror,-Wuninitialized]
                        if (stream && (ext_intr_stat1 & stream->irq_bit)) {
                                       ^~~~~~~~~~~~~~
../sound/soc/amd/acp/acp-platform.c:97:35: note: initialize the variable 'ext_intr_stat1' to silence this warning
        u32 ext_intr_stat, ext_intr_stat1, i;
                                         ^
                                          = 0
1 error generated.

Patch submitted: https://lore.kernel.org/20220725180539.1315066-1-nathan@kernel.org/
@nathanchance nathanchance added [PATCH] Submitted A patch has been submitted for review -Wuninitialized [BUG] linux-next This is an issue only seen in linux-next labels Jul 25, 2022
@nathanchance nathanchance self-assigned this Jul 25, 2022
intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this issue Jul 25, 2022
@nathanchance @intel-lab-lkp
ASoC: amd: acp: Fix initialization of ext_intr_stat1 in i2s_irq_handl…
a048b65 
…er()

Clang warns:

  ../sound/soc/amd/acp/acp-platform.c:117:19: error: variable 'ext_intr_stat1' is uninitialized when used here [-Werror,-Wuninitialized]
                          if (stream && (ext_intr_stat1 & stream->irq_bit)) {
                                         ^~~~~~~~~~~~~~
  ../sound/soc/amd/acp/acp-platform.c:97:35: note: initialize the variable 'ext_intr_stat1' to silence this warning
          u32 ext_intr_stat, ext_intr_stat1, i;
                                           ^
                                            = 0
  1 error generated.

The variable was not properly renamed, correct it to resolve the
warning.

Fixes: 93f5388 ("ASoC: amd: acp: Modify local variables name to generic")
Link: ClangBuiltLinux#1675
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
ammarfaizi2 pushed a commit to ammarfaizi2/linux-block that referenced this issue Jul 26, 2022
@nathanchance @broonie
ASoC: amd: acp: Fix initialization of ext_intr_stat1 in i2s_irq_handl…
d816774 
…er()

Clang warns:

  ../sound/soc/amd/acp/acp-platform.c:117:19: error: variable 'ext_intr_stat1' is uninitialized when used here [-Werror,-Wuninitialized]
                          if (stream && (ext_intr_stat1 & stream->irq_bit)) {
                                         ^~~~~~~~~~~~~~
  ../sound/soc/amd/acp/acp-platform.c:97:35: note: initialize the variable 'ext_intr_stat1' to silence this warning
          u32 ext_intr_stat, ext_intr_stat1, i;
                                           ^
                                            = 0
  1 error generated.

The variable was not properly renamed, correct it to resolve the
warning.

Fixes: 93f5388 ("ASoC: amd: acp: Modify local variables name to generic")
Link: ClangBuiltLinux/linux#1675
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Tom Rix <trix@redhat.com>
Link: https://lore.kernel.org/r/20220725180539.1315066-1-nathan@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
@nathanchance
Copy link
Member Author

Patch accepted: https://git.kernel.org/broonie/sound/c/d81677410f172c2b946393c09b46ff9e8dc1b6ec

@nathanchance nathanchance added [PATCH] Accepted A submitted patch has been accepted upstream and removed [PATCH] Submitted A patch has been submitted for review labels Jul 26, 2022
@nathanchance
Copy link
Member Author

Now in next-20220727.

@nathanchance nathanchance added [FIXED][LINUX] development cycle This bug was only present and fixed in a -next or -rc cycle and removed [PATCH] Accepted A submitted patch has been accepted upstream labels Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nathanchance nathanchance

Labels
-Wuninitialized [BUG] linux-next This is an issue only seen in linux-next [FIXED][LINUX] development cycle This bug was only present and fixed in a -next or -rc cycle
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nathanchance